All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil@xs4all.nl>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Subject: [PATCH 12/11] adv7604/cobalt: missing GPIOLIB dependency
Date: Fri, 22 May 2015 16:06:35 +0200	[thread overview]
Message-ID: <555F37EB.6040404@xs4all.nl> (raw)
In-Reply-To: <1432303184-8594-12-git-send-email-hverkuil@xs4all.nl>

The adv7604 driver depends on GPIOLIB, and therefore cobalt depends
on it as well.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
---
 drivers/media/i2c/Kconfig        | 2 +-
 drivers/media/pci/cobalt/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
index 6f30ea7..36f5563 100644
--- a/drivers/media/i2c/Kconfig
+++ b/drivers/media/i2c/Kconfig
@@ -196,7 +196,7 @@ config VIDEO_ADV7183
 
 config VIDEO_ADV7604
 	tristate "Analog Devices ADV7604 decoder"
-	depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API
+	depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API && GPIOLIB
 	---help---
 	  Support for the Analog Devices ADV7604 video decoder.
 
diff --git a/drivers/media/pci/cobalt/Kconfig b/drivers/media/pci/cobalt/Kconfig
index e3c03e9..3be1b2c 100644
--- a/drivers/media/pci/cobalt/Kconfig
+++ b/drivers/media/pci/cobalt/Kconfig
@@ -1,7 +1,7 @@
 config VIDEO_COBALT
 	tristate "Cisco Cobalt support"
 	depends on VIDEO_V4L2 && I2C && MEDIA_CONTROLLER
-	depends on PCI_MSI && MTD_COMPLEX_MAPPINGS
+	depends on PCI_MSI && MTD_COMPLEX_MAPPINGS && GPIOLIB
 	select I2C_ALGOBIT
 	select VIDEO_ADV7604
 	select VIDEO_ADV7511
-- 
2.1.4



On 05/22/2015 03:59 PM, Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
> 
> drivers/media/pci/saa7164/saa7164-i2c.c:45:33: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
>  drivers/media/pci/saa7164/saa7164-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/saa7164/saa7164-i2c.c b/drivers/media/pci/saa7164/saa7164-i2c.c
> index 6ea9d4f..0342d84 100644
> --- a/drivers/media/pci/saa7164/saa7164-i2c.c
> +++ b/drivers/media/pci/saa7164/saa7164-i2c.c
> @@ -42,7 +42,7 @@ static int i2c_xfer(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs, int num)
>  			retval = saa7164_api_i2c_read(bus,
>  				msgs[i].addr,
>  				0 /* reglen */,
> -				0 /* reg */, msgs[i].len, msgs[i].buf);
> +				NULL /* reg */, msgs[i].len, msgs[i].buf);
>  		} else if (i + 1 < num && (msgs[i + 1].flags & I2C_M_RD) &&
>  			   msgs[i].addr == msgs[i + 1].addr) {
>  			/* write then read from same address */
> 


  reply	other threads:[~2015-05-22 14:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 13:59 [PATCH 00/11] cobalt bug fixes, fixes for compiler/sparse warnings Hans Verkuil
2015-05-22 13:59 ` [PATCH 01/11] cobalt: fix irqs used for the adv7511 transmitter Hans Verkuil
2015-05-22 13:59 ` [PATCH 02/11] cobalt: fix 64-bit division link error Hans Verkuil
2015-05-22 13:59 ` [PATCH 03/11] cobalt: fix compiler warnings on 32 bit OSes Hans Verkuil
2015-05-22 13:59 ` [PATCH 04/11] e4000: fix compiler warning Hans Verkuil
2015-05-22 13:59 ` [PATCH 05/11] cobalt: fix sparse warnings Hans Verkuil
2015-05-22 13:59 ` [PATCH 06/11] " Hans Verkuil
2015-05-22 13:59 ` [PATCH 07/11] " Hans Verkuil
2015-05-22 13:59 ` [PATCH 08/11] " Hans Verkuil
2015-05-22 13:59 ` [PATCH 09/11] " Hans Verkuil
2015-05-22 13:59 ` [PATCH 10/11] cx24120: fix sparse warning Hans Verkuil
2015-05-22 13:59 ` [PATCH 11/11] saa7164: " Hans Verkuil
2015-05-22 14:06   ` Hans Verkuil [this message]
2015-05-22 14:21   ` Steven Toth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555F37EB.6040404@xs4all.nl \
    --to=hverkuil@xs4all.nl \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.