From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvuih-0003yQ-Hi for qemu-devel@nongnu.org; Fri, 22 May 2015 17:43:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yvuid-0000Qu-6A for qemu-devel@nongnu.org; Fri, 22 May 2015 17:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvuic-0000Qm-UN for qemu-devel@nongnu.org; Fri, 22 May 2015 17:43:03 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MLh1hK004284 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 17:43:01 -0400 Message-ID: <555FA2E4.2000409@redhat.com> Date: Fri, 22 May 2015 15:43:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-5-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5NWouWAK2N31DG5hP0le1QwMKg2rwsjK9" Subject: Re: [Qemu-devel] [PATCH 04/20] monitor: Convert client_migrate_info to QAPI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5NWouWAK2N31DG5hP0le1QwMKg2rwsjK9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > hmp-commands.hx | 3 +-- > hmp.c | 17 +++++++++++++++++ > hmp.h | 1 + > monitor.c | 42 ++++++++++++++++++------------------------ > qapi-schema.json | 20 ++++++++++++++++++++ > qmp-commands.hx | 2 +- > 6 files changed, 58 insertions(+), 27 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -638,6 +638,26 @@ > 'returns': 'MigrationParameters' } > =20 > ## > +# @client_migrate_info Should we name this new command 'client-migrate-info'? /me goes and checks... Oh, wow, the QMP command IS advertised by 'query-commands' in spite of not having this wrapper, even in qemu 2.3. > +# > +# Set the spice/vnc connection info for the migration target. The > +# spice/vnc server will ask the spice/vnc client to automatically > +# reconnect using the new parameters (if specified) once the vm > +# migration finished successfully. Not yet implemented for VNC. > +# > +# @protocol: must be "spice" > +# @hostname: migration target hostname > +# @port: #optional spice/vnc tcp port for plaintext channels Is it worth documenting vnc, when we just stated earlier that protocol must be spice? > +# @tls-port: #optional spice tcp port for tls-secured channels > +# @cert-subject: #optional server certificate subject > +# > +# Since: 0.14.0 So this 'Since:' designation is correct, and we are just _finally_ documenting something that has silently been sitting around in QMP for a looooong time. > +## > +{ 'command': 'client_migrate_info', > + 'data': { 'protocol': 'str', 'hostname': 'str', '*port': 'int', > + '*tls-port': 'int', '*cert-subject': 'str' } } Idea for followups - since 'protocol' must be "spice", should we: 1) make it an enum type rather than open-coded str 2) make it an optional parameter, so that omitting it defaults to spice? > + > +## > # @MouseInfo: > # > # Information about a mouse device. > diff --git a/qmp-commands.hx b/qmp-commands.hx > index c267c89..4611b6b 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -785,7 +785,7 @@ EQMP > .args_type =3D "protocol:s,hostname:s,port:i?,tls-port:i?,cer= t-subject:s?", > .params =3D "protocol hostname port tls-port cert-subject"= , > .help =3D "send migration info to spice/vnc client", > - .mhandler.cmd_new =3D client_migrate_info, > + .mhandler.cmd_new =3D qmp_marshal_input_client_migrate_info, How many entries in qmp-commands.hx are NOT present in qapi? It looks like this patch gets us one step closer to ditching the need to maintain this file, which is a good thing. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5NWouWAK2N31DG5hP0le1QwMKg2rwsjK9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX6LkAAoJEKeha0olJ0NqBh8IAKfMRcPvV6rYa9SVp4/u/UmX 1+l1XB9mvH5vHxNxpJsC7htY4vmA/sHG13DmO294XigOEcqlgwf44vNzYdk8+pf0 Ez12i65y38YmoyCizH81LxZk4N9OAKpCQCKoYeqTf/gEwKhfsUx64eOc36eQv1pN i724bs7BPmlNOqMUFSywfSSoDHt0JApsHbr88swFhBeoQeXuMMIDBgI/EWtbHgeJ HY2lJs8ecB6oMuyewmJEgNChGDxG5r++rjnCui0wtiFgyJkzn9jQ9eCNy3+B6c7t vqTxjYTSe5A7BGkMlMpz1J+nbqYg3arzAmDgK9aiAu+zdubkAHcR4ta5Td7tMp8= =dC0P -----END PGP SIGNATURE----- --5NWouWAK2N31DG5hP0le1QwMKg2rwsjK9--