From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvvi8-0007kA-07 for qemu-devel@nongnu.org; Fri, 22 May 2015 18:46:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yvvi4-0007Po-Pg for qemu-devel@nongnu.org; Fri, 22 May 2015 18:46:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yvvi4-0007PY-IP for qemu-devel@nongnu.org; Fri, 22 May 2015 18:46:32 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4MMkVwU003328 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 22 May 2015 18:46:31 -0400 Message-ID: <555FB1C6.3010801@redhat.com> Date: Fri, 22 May 2015 16:46:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1432294585-5984-1-git-send-email-armbru@redhat.com> <1432294585-5984-16-git-send-email-armbru@redhat.com> In-Reply-To: <1432294585-5984-16-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I2Ti2vIAik7OalWlRav09cmIvwXJeVpCw" Subject: Re: [Qemu-devel] [PATCH 15/20] monitor: Rename monitor_control_read(), monitor_control_event() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I2Ti2vIAik7OalWlRav09cmIvwXJeVpCw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/22/2015 05:36 AM, Markus Armbruster wrote: > ... to monitor_qmp_read(), monitor_qmp_event(). >=20 > Signed-off-by: Markus Armbruster > --- > monitor.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) Not a trivial rename based on diffstat, but... >=20 > diff --git a/monitor.c b/monitor.c > index ecadda7..977c0fd 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -5043,10 +5043,7 @@ err_out: > QDECREF(args); > } > =20 > -/** > - * monitor_control_read(): Read and handle QMP input > - */ > -static void monitor_control_read(void *opaque, const uint8_t *buf, int= size) > +static void monitor_qmp_read(void *opaque, const uint8_t *buf, int siz= e) Drops a comment, but the comment didn't add much. > { > Monitor *old_mon =3D cur_mon; > =20 > @@ -5111,10 +5108,7 @@ static QObject *get_qmp_greeting(void) > return qobject_from_jsonf("{'QMP':{'version': %p,'capabilities': [= ]}}",ver); > } > =20 > -/** > - * monitor_control_event(): Print QMP gretting > - */ > -static void monitor_control_event(void *opaque, int event) > +static void monitor_qmp_event(void *opaque, int event) Drops a typo in the otherwise useless comment. (I'm surprised numerous scans for spelling cleanups haven't yet flagged "gretting" as unusual). =2E..so I'm okay with it. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --I2Ti2vIAik7OalWlRav09cmIvwXJeVpCw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVX7HGAAoJEKeha0olJ0NqxMUH/0iwACinPbdna4A2LNnSZJJX x9y1aVtLwN2ixSklaNzfrNAxyj68Ly2YApAUG4OT8tLj5UJUibU4wmznGzxD7cQx uaIZtrwZjGRFTMJvun92+5A+PoQ65DeNbEVQvHZeAAqiU22Iya+ReYe+8bTd2dK8 lsp/g+sPZYmCCgqftUD11Db/+jfwlFIGC4tEDLzhmB3bZwCiWH4bKuiIRoNOTL22 yjpp9FbvV3iFOOOWJCdLwnxmldn0+7rB0HjS5uwBp2X7sVtm3hB5eypgwei6QCqT exQkLS5bLbb3OjWrouG2xre17VXhhjjX/Uctn4KbzYOGtDpo2g1ojixZ3RGSm2I= =20Jx -----END PGP SIGNATURE----- --I2Ti2vIAik7OalWlRav09cmIvwXJeVpCw--