From: Guenter Roeck <linux@roeck-us.net>
To: linux-kernel@vger.kernel.org
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Steven Miao <realmz6@gmail.com>,
adi-buildroot-devel@lists.sourceforge.net
Subject: Re: [PATCH resend 5/5] blackfin: Fix build error
Date: Fri, 22 May 2015 21:25:32 -0700 [thread overview]
Message-ID: <5560013C.5060307@roeck-us.net> (raw)
In-Reply-To: <1430778649-28126-6-git-send-email-linux@roeck-us.net>
ping ....
On 05/04/2015 03:30 PM, Guenter Roeck wrote:
> Fix
>
> include/asm-generic/io.h: In function 'readb':
> include/asm-generic/io.h:113:2: error:
> implicit declaration of function 'bfin_read8'
> include/asm-generic/io.h: In function 'readw':
> include/asm-generic/io.h:121:2: error:
> implicit declaration of function 'bfin_read16'
> include/asm-generic/io.h: In function 'readl':
> include/asm-generic/io.h:129:2: error:
> implicit declaration of function 'bfin_read32'
> include/asm-generic/io.h: In function 'writeb':
> include/asm-generic/io.h:147:2: error:
> implicit declaration of function 'bfin_write8'
> include/asm-generic/io.h: In function 'writew':
> include/asm-generic/io.h:155:2: error:
> implicit declaration of function 'bfin_write16'
> include/asm-generic/io.h: In function 'writel':
> include/asm-generic/io.h:163:2: error:
> implicit declaration of function 'bfin_write32'
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: 1a3372bc522ef ("blackfin: io: define __raw_readx/writex with
> bfin_readx/writex")
> Cc: Steven Miao <realmz6@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> Please consider pushing this patch into mainline, or provide feedback
> on how to improve it to be acceptable.
>
> arch/blackfin/include/asm/io.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/blackfin/include/asm/io.h b/arch/blackfin/include/asm/io.h
> index 4e8ad0523118..6abebe82d4e9 100644
> --- a/arch/blackfin/include/asm/io.h
> +++ b/arch/blackfin/include/asm/io.h
> @@ -10,6 +10,7 @@
> #include <linux/compiler.h>
> #include <linux/types.h>
> #include <asm/byteorder.h>
> +#include <asm/def_LPBlackfin.h>
>
> #define __raw_readb bfin_read8
> #define __raw_readw bfin_read16
>
prev parent reply other threads:[~2015-05-23 4:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 22:30 [PATCH resend 0/5] Fix various build errors Guenter Roeck
2015-05-04 22:30 ` [PATCH resend 1/5] spi: bcm2835: Add GPIOLIB dependency Guenter Roeck
[not found] ` <1430778649-28126-2-git-send-email-linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-05-04 23:34 ` Mark Brown
2015-05-04 23:34 ` Mark Brown
[not found] ` <20150504233421.GW22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-05 0:02 ` Guenter Roeck
2015-05-05 0:02 ` Guenter Roeck
[not found] ` <55480894.3080200-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-05-05 2:00 ` Guenter Roeck
2015-05-05 2:00 ` Guenter Roeck
[not found] ` <55482457.2020005-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-05-05 11:16 ` Mark Brown
2015-05-05 11:16 ` Mark Brown
[not found] ` <20150505111646.GB22845-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-05-05 11:32 ` Geert Uytterhoeven
2015-05-05 11:32 ` Geert Uytterhoeven
[not found] ` <CAMuHMdXfW6ngPDNgzoe8FjNV9kC6YCo85C75umta5cC67WRVrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-05 11:40 ` Mark Brown
2015-05-05 11:40 ` Mark Brown
2015-05-05 10:28 ` Mark Brown
2015-05-05 10:28 ` Mark Brown
2015-05-04 22:30 ` [PATCH resend 2/5] mips: Fix SMP builds Guenter Roeck
2015-05-04 22:30 ` [PATCH resend 3/5] xtensa: Provide dummy dma_alloc_attrs() and dma_free_attrs() Guenter Roeck
2015-05-04 22:35 ` Chris Zankel
2015-05-23 4:24 ` Guenter Roeck
2015-05-04 22:30 ` [PATCH resend 4/5] score: Fix exception handler label Guenter Roeck
2015-05-06 2:00 ` Lennox Wu
2015-05-23 4:24 ` Guenter Roeck
2015-05-25 14:56 ` Lennox Wu
2015-05-04 22:30 ` [PATCH resend 5/5] blackfin: Fix build error Guenter Roeck
2015-05-06 9:15 ` Steven Miao
2015-05-23 4:25 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5560013C.5060307@roeck-us.net \
--to=linux@roeck-us.net \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=realmz6@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.