All of lore.kernel.org
 help / color / mirror / Atom feed
From: LiaoQingwei <liaoqingwei@huawei.com>
To: liaoqingwei <liaoqingwei@huawei.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2] controllers/cpuacct: tst_brkm() instead of echo failed message
Date: Sat, 23 May 2015 19:02:18 +0800	[thread overview]
Message-ID: <55605E3A.3040000@huawei.com> (raw)
In-Reply-To: <1432404112-12132-1-git-send-email-liaoqingwei@huawei.com>

Please forgive my careless,I send a wrong patch,please ignored.The patch v2 maybe right.
Thanks.

Most of the time,the reason of mount cgroup failed is the configuration
is not enabled,for example,CONFIG_CGROUP_CPUACCT=no.
I think use TCONF message is more helpful,and use basic test interface
tst_brkm instead of echo failed message.

Signed-off-by: Liao Qingwei <liaoqingwei@huawei.com>
---
 testcases/kernel/controllers/cpuacct/cpuacct_setup.sh | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
index 6eab1b4..f9c4fb8 100755
--- a/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
+++ b/testcases/kernel/controllers/cpuacct/cpuacct_setup.sh
@@ -97,10 +97,8 @@ setup()
        mount -t cgroup -ocpuacct none /dev/cpuacct 2> /dev/null
        if [ $? -ne 0 ]
        then
-               echo "TFAIL: Could not mount cgroup filesystem"
-               echo "Exiting test"
-               cleanup
-               exit 1
+                tst_brkm TCONF cleanup "Could not mount cgroup filesystem,Maybe the configuration is not enabled"
+               exit 0
        fi

        # Group created earlier may again be visible if not cleaned properly.
-- 
1.9.1


------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2015-05-23 11:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-23 18:01 [LTP] [PATCH] controllers/cpuacct: tst_brkm() instead of exit liaoqingwei
2015-05-23 11:02 ` LiaoQingwei [this message]
2015-05-25  2:51   ` [LTP] [PATCH v2] controllers/cpuacct: tst_brkm() instead of echo failed message Cui Bixuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55605E3A.3040000@huawei.com \
    --to=liaoqingwei@huawei.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.