From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754905AbbEXCya (ORCPT <rfc822;w@1wt.eu>);
	Sat, 23 May 2015 22:54:30 -0400
Received: from mail-pd0-f174.google.com ([209.85.192.174]:34849 "EHLO
	mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751456AbbEXCy3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 May 2015 22:54:29 -0400
Message-ID: <55613D63.9070505@gmail.com>
Date: Sat, 23 May 2015 19:54:27 -0700
From: tolga ceylan <tolga.ceylan@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Benjamin Romer <benjamin.romer@unisys.com>,
        David Kershner <david.kershner@unisys.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jes Sorensen <Jes.Sorensen@redhat.com>, sparmaintainer@unisys.com,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c:
 private functions should be declared static
References: <1431750141-5660-1-git-send-email-tolga.ceylan@gmail.com>
In-Reply-To: <1431750141-5660-1-git-send-email-tolga.ceylan@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
> visorchipset_file_init() and visorchipset_file_cleanup() functions
> do not seem to be used from anywhere else and now are declared
> as static. Sparse emitted "not declared" warnings for these two
> functions.
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
>   drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index ca22f49..66ae3d0 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
>   	.mmap = visorchipset_mmap,
>   };
>
> -int
> +static int
>   visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
>   {
>   	int rc = 0;
> @@ -2460,7 +2460,7 @@ cleanup:
>   	return rc;
>   }
>
> -void
> +static void
>   visorchipset_file_cleanup(dev_t major_dev)
>   {
>   	if (file_cdev.ops)
>

I haven't received a response for this patch. Just checking back.

Regards,
Tolga Ceylan