All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] wandboard: Add board revision detection support
Date: Sun, 24 May 2015 16:30:24 +0200	[thread overview]
Message-ID: <5561E080.5060009@denx.de> (raw)
In-Reply-To: <CAOMZO5Cm7FNb5Jgfx15qVJGDAs5BCbvZamfk0kz=1SZWe8_qAg@mail.gmail.com>

Hi Fabio,

On 24/05/2015 16:27, Fabio Estevam wrote:
> 
> I think the idea is good, thanks.
> 
> I wanted to keep consistency with the mx6cuboxi implementation (which
> was based on TI's implementation suggested by Tom during the review of
> the mx6cuboxi patches).
> 
> Also, the gpio script idea would work fine for selecting the dtb file,
> but not inside checkboard() function, where I print the board revision
> name.
> 
> Other aspect I thought is the fact that in case we have another
> revision of the board in the future, I think that C code is more
> flexible for handling it.

This is a good point, thanks.

> 
> So I like the idea of gpio script, but I would prefer to keep the
> current implementation if possible due to the reasons stated above.
> 

ok, clear enough - on my site it is ok to maintain current implementation.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2015-05-24 14:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 22:24 [U-Boot] [PATCH v2] wandboard: Add board revision detection support Fabio Estevam
2015-05-22  7:49 ` Stefano Babic
2015-05-23  0:38 ` Vagrant Cascadian
2015-05-23 16:27   ` Alexander Holler
2015-05-24  7:43     ` Stefano Babic
2015-05-24 14:27       ` Fabio Estevam
2015-05-24 14:30         ` Stefano Babic [this message]
2015-05-24 17:29         ` Alexander Holler
2015-05-24 18:03           ` Alexander Holler
2015-05-24 18:47             ` Fabio Estevam
2015-05-24 22:22               ` Alexander Holler
2015-05-24 23:42                 ` Fabio Estevam
2015-05-25  9:41                   ` Wolfgang Denk
2015-05-25 11:25                     ` Fabio Estevam
2015-05-26 18:55                     ` Alexander Holler
2015-05-26 22:11                       ` Fabio Estevam
2015-05-24 19:03             ` Tom Rini
2015-05-24 18:44           ` Fabio Estevam
2015-06-08  6:35 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5561E080.5060009@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.