All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francis Laniel <flaniel@linux.microsoft.com>
To: buildroot@buildroot.org, Arnout Vandecappelle <arnout@mind.be>
Cc: Angelo Compagnucci <angelo.compagnucci@gmail.com>,
	Samuel Martin <s.martin49@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [RFC PATCH v4 1/2] falcosecurity-libs: add new package
Date: Tue, 03 May 2022 15:15:59 +0100	[thread overview]
Message-ID: <5563067.DvuYhMxLoT@pwmachine> (raw)
In-Reply-To: <bd76474e-7711-7bc2-83b8-5babd021cc39@mind.be>

Hi!

Le samedi 30 avril 2022, 18:57:04 BST Arnout Vandecappelle a écrit :
> On 25/04/2022 18:43, Francis Laniel wrote:
> > Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> 
>   I've added a bit of explanation both in the commit message and in the .mk
> file itself that we're not building the userspace components and why.
> 
> > ---
> > 
> >   DEVELOPERS                                    |  1 +
> >   package/Config.in                             |  1 +
> >   ...cmake-Permit-setting-GRPC_CPP_PLUGIN.patch | 34 ++++++++
> >   package/falcosecurity-libs/Config.in          | 30 +++++++
> >   .../falcosecurity-libs.hash                   |  5 ++
> >   .../falcosecurity-libs/falcosecurity-libs.mk  | 80 +++++++++++++++++++
> >   6 files changed, 151 insertions(+)
> >   create mode 100644
> >   package/falcosecurity-libs/0001-cmake-Permit-setting-GRPC_CPP_PLUGIN.pa
> >   tch create mode 100644 package/falcosecurity-libs/Config.in
> >   create mode 100644 package/falcosecurity-libs/falcosecurity-libs.hash
> >   create mode 100644 package/falcosecurity-libs/falcosecurity-libs.mk
> > 
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index ca9decb58f..d45d3d2a7b 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -969,6 +969,7 @@ F:	package/ipmitool/
> > 
> >   F:	package/odhcploc/
> >   
> >   N:	Francis Laniel <flaniel@linux.microsoft.com>
> > 
> > +F:	package/falcosecurity-libs
> > 
> >   F:	package/pahole/
> >   F:	package/sysdig/
> >   F:	package/tbb/
> > 
> > diff --git a/package/Config.in b/package/Config.in
> > index 24f7af5ea8..3070094cc0 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -1935,6 +1935,7 @@ menu "Other"
> > 
> >   	source "package/eigen/Config.in"
> >   	source "package/elfutils/Config.in"
> >   	source "package/ell/Config.in"
> > 
> > +	source "package/falcosecurity-libs/Config.in"
> > 
> >   	source "package/fftw/Config.in"
> >   	source "package/flann/Config.in"
> >   	source "package/flatbuffers/Config.in"
> > 
> > diff --git
> > a/package/falcosecurity-libs/0001-cmake-Permit-setting-GRPC_CPP_PLUGIN.pa
> > tch
> > b/package/falcosecurity-libs/0001-cmake-Permit-setting-GRPC_CPP_PLUGIN.pa
> > tch new file mode 100644
> > index 0000000000..6141d8ef72
> > --- /dev/null
> > +++
> > b/package/falcosecurity-libs/0001-cmake-Permit-setting-GRPC_CPP_PLUGIN.pa
> > tch @@ -0,0 +1,34 @@
> > +From 2e8a50cd4975df3ab60ee07c9675831cd5ad397f Mon Sep 17 00:00:00 2001
> > +From: Francis Laniel <flaniel@linux.microsoft.com>
> > +Date: Tue, 12 Apr 2022 19:54:11 +0100
> > +Subject: [PATCH] cmake: Permit setting GRPC_CPP_PLUGIN.
> > +
> > +This patch enables users to set GRPC_CPP_PLUGIN while calling cmake with:
> > +cmake -DGRPC_CPP_PLUGIN=/path
> > +
> > +Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> 
>   Could you send this patch upstream?

Oh sorry, I sent the nlohmann-json one but forgot about it!
I will try to upstream it!

> 
>   Applied to master, thanks.

Thank you!

>   Regards,
>   Arnout
> 
> [snip]

Best regards.


_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-05-03 14:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25 16:43 [Buildroot] [RFC PATCH v4 0/2] Bump sysdig to 0.29.1 Francis Laniel
2022-04-25 16:43 ` [Buildroot] [RFC PATCH v4 1/2] falcosecurity-libs: add new package Francis Laniel
2022-04-30 17:57   ` Arnout Vandecappelle
2022-05-03 14:15     ` Francis Laniel [this message]
2022-04-25 16:43 ` [Buildroot] [RFC PATCH v4 2/2] package/sysdig: bump to 0.29.1 Francis Laniel
2022-04-30 18:07   ` Arnout Vandecappelle
2022-05-03 14:15     ` Francis Laniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5563067.DvuYhMxLoT@pwmachine \
    --to=flaniel@linux.microsoft.com \
    --cc=angelo.compagnucci@gmail.com \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=s.martin49@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.