All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: airlied@linux.ie
Cc: dri-devel@lists.freedesktop.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"oleg@redhat.com" <oleg@redhat.com>
Subject: block_all_signals() usage in DRM
Date: Mon, 25 May 2015 16:59:38 +0200	[thread overview]
Message-ID: <556338DA.6000404@nod.at> (raw)

Hi!

drivers/gpu/drm/drm_lock.c is the only remaining user of block_all_signals():
        /* don't set the block all signals on the master process for now
         * really probably not the correct answer but lets us debug xkb
         * xserver for now */
        if (!file_priv->is_master) {
                sigemptyset(&dev->sigmask);
                sigaddset(&dev->sigmask, SIGSTOP);
                sigaddset(&dev->sigmask, SIGTSTP);
                sigaddset(&dev->sigmask, SIGTTIN);
                sigaddset(&dev->sigmask, SIGTTOU);
                dev->sigdata.context = lock->context;
                dev->sigdata.lock = master->lock.hw_lock;
                block_all_signals(drm_notifier, dev, &dev->sigmask);
        }

Is this functionality still in use/needed?
Otherwise we could get rid of block_all_signals() and unpuzzle the signaling
code a bit. :-)

Thanks,
//richard

             reply	other threads:[~2015-05-25 14:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 14:59 Richard Weinberger [this message]
2015-05-25 16:50 ` block_all_signals() usage in DRM Oleg Nesterov
2015-05-25 17:15   ` Richard Weinberger
2015-05-25 21:36   ` Dave Airlie
2015-05-25 21:36     ` Dave Airlie
2015-05-25 21:31 ` Dave Airlie
2015-05-25 21:31   ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556338DA.6000404@nod.at \
    --to=richard@nod.at \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.