From: Larry Finger <Larry.Finger@lwfinger.net>
To: 1432415812-1285-1-git-send-email-Larry.Finger@lwfinger.net,
haggai.eran@gmail.com
Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Stable <stable@vger.kernel.org>,
Arek Rusniak <arek.rusi@gmail.com>
Subject: Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()
Date: Mon, 25 May 2015 10:59:43 -0500 [thread overview]
Message-ID: <556346EF.8000804@lwfinger.net> (raw)
In-Reply-To: <20150525044250.GA3385@sudip-PC>
On 05/24/2015 11:42 PM, Sudip Mukherjee wrote:
>> I haven't been using kernel v4.1 so I haven't seen this warning, but looking
>> at the code it seems to originate from the two recent patches to remove
>> _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1]
>> that changes del_timer_sync back to del_timer in more places. Perhaps it
>> could prevent other warnings like this in the future.
>
> _cancel_timer and _cancel_timer_ex both were internally using del_timer,
> and the issue was reported in bugzilla. I have given the reference of the
> bugzilla in my patch in lkml.
> I have changed the reference of del_timer_sync to del_timer in all places
> which were in interrupt context, in some places it was not removed as
> those were not in interrupt context.
Why did you not Cc the maintainers?? That is why file MAINTAINERS exists.
Was your patch sent to Greg?
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: 1432415812-1285-1-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org,
haggai.eran-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stable <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Arek Rusniak <arek.rusi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync()
Date: Mon, 25 May 2015 10:59:43 -0500 [thread overview]
Message-ID: <556346EF.8000804@lwfinger.net> (raw)
In-Reply-To: <20150525044250.GA3385@sudip-PC>
On 05/24/2015 11:42 PM, Sudip Mukherjee wrote:
>> I haven't been using kernel v4.1 so I haven't seen this warning, but looking
>> at the code it seems to originate from the two recent patches to remove
>> _cancel_timer and _cancel_timer_ex. I see that there's another patch in lkml [1]
>> that changes del_timer_sync back to del_timer in more places. Perhaps it
>> could prevent other warnings like this in the future.
>
> _cancel_timer and _cancel_timer_ex both were internally using del_timer,
> and the issue was reported in bugzilla. I have given the reference of the
> bugzilla in my patch in lkml.
> I have changed the reference of del_timer_sync to del_timer in all places
> which were in interrupt context, in some places it was not removed as
> those were not in interrupt context.
Why did you not Cc the maintainers?? That is why file MAINTAINERS exists.
Was your patch sent to Greg?
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-05-25 15:59 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 4:42 [PATCH] staging: r8712u: Fix kernel warning for improper call of del_timer_sync() Sudip Mukherjee
2015-05-25 15:59 ` Larry Finger [this message]
2015-05-25 15:59 ` Larry Finger
-- strict thread matches above, loose matches on Subject: below --
2015-05-23 21:16 Larry Finger
2015-05-24 19:03 ` Haggai Eran
2015-05-25 0:11 ` Larry Finger
2015-05-25 9:17 ` Dan Carpenter
2015-05-25 9:17 ` Dan Carpenter
[not found] ` <CAK-LDb+1WscLTFw=NDY=_aUOGw72a4wRsqCU-1N+KJ11k15S5w@mail.gmail.com>
2015-05-25 10:12 ` Dan Carpenter
2015-05-25 10:12 ` Dan Carpenter
2015-05-25 15:52 ` Larry Finger
2015-05-25 15:52 ` Larry Finger
2015-05-25 17:37 ` Joe Perches
2015-05-25 17:37 ` Joe Perches
2015-05-26 4:46 ` Sudip Mukherjee
2015-05-26 4:46 ` Sudip Mukherjee
2015-05-26 4:55 ` Joe Perches
2015-05-26 4:55 ` Joe Perches
2015-05-26 5:02 ` Sudip Mukherjee
2015-05-26 5:02 ` Sudip Mukherjee
2015-05-26 5:07 ` Joe Perches
2015-05-26 5:30 ` Sudip Mukherjee
2015-05-26 5:30 ` Sudip Mukherjee
2015-05-26 15:31 ` Larry Finger
2015-05-26 14:14 ` Greg KH
2015-05-26 14:14 ` Greg KH
2015-05-26 14:48 ` Joe Perches
2015-05-26 16:35 ` Greg KH
2015-05-26 17:06 ` Joe Perches
2015-05-26 20:25 ` Dan Carpenter
2015-05-26 20:25 ` Dan Carpenter
2015-05-26 20:30 ` Greg KH
2015-05-26 20:09 ` Dan Carpenter
2015-05-26 20:09 ` Dan Carpenter
2015-05-26 15:48 ` Dan Carpenter
2015-05-26 15:48 ` Dan Carpenter
2015-05-26 16:40 ` Larry Finger
2015-05-25 16:02 ` Larry Finger
2015-05-31 2:53 ` Greg KH
2015-05-31 2:53 ` Greg KH
2015-05-31 2:54 ` Greg KH
2015-05-31 2:54 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556346EF.8000804@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=1432415812-1285-1-git-send-email-Larry.Finger@lwfinger.net \
--cc=arek.rusi@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=haggai.eran@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.