All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Shailendra Verma <shailendra.capricorn@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] char:agp:amd64-agp - Change 1 to true for bool type
Date: Mon, 25 May 2015 23:22:20 +0200	[thread overview]
Message-ID: <5563928C.1030002@nod.at> (raw)
In-Reply-To: <CA+tKcn-jTHbzk2FGhfxQA6wGQqY+JWRS6S4+BJmWhkwt3ppWqQ@mail.gmail.com>

Am 25.05.2015 um 23:14 schrieb Shailendra Verma:
> Hello Richard,
> 
> I will separate both the changes and will send the patches to you.
> 
> What issue does this fix? IOW why is assigning 1 wrong?
> 
>>>>> Yes, you are correct. There will be no issue in assigning 1 to the variable. But according to coding guidelines we should only use true/false for bool type variables.

Really? I don't see this in Documentation/CodingStyle and checkpatch.pl does not bark either.
IMHO it is a matter of taste. But the individual maintainer has to decide. :-)

Thanks,
//richard

P.s: Please don't crop the list of CC when replying.

  parent reply	other threads:[~2015-05-25 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-25 19:18 [PATCH] char:agp:amd64-agp - Change 1 to true for bool type Shailendra Verma
2015-05-25 19:24 ` Richard Weinberger
     [not found]   ` <CA+tKcn-jTHbzk2FGhfxQA6wGQqY+JWRS6S4+BJmWhkwt3ppWqQ@mail.gmail.com>
2015-05-25 21:22     ` Richard Weinberger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-05-27  1:41 Shailendra Verma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5563928C.1030002@nod.at \
    --to=richard@nod.at \
    --cc=airlied@linux.ie \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shailendra.capricorn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.