From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Klausmann Subject: Re: [PATCH 1/2] nv30/draw: rework some of the output vertex buffer logic Date: Tue, 26 May 2015 02:42:04 +0200 Message-ID: <5563C15C.102@mni.thm.de> References: <1432582152-29389-1-git-send-email-imirkin@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1432582152-29389-1-git-send-email-imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Ilia Mirkin , nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: nouveau.vger.kernel.org CgpPbiAyNS4wNS4yMDE1IDIxOjI5LCBJbGlhIE1pcmtpbiB3cm90ZToKPiBUaGlzIG1ha2VzIHRo ZSB2ZXJ0ZXggYnVmZmVyIGdvIHRvIEdBUlQsIG5vdCBWUkFNLCBhbmQgcmVkb2VzIHRoZQo+IG1h cHBpbmcgdG8gbm90IHVzZSB0aGUgVU5TWU5DSFJPTklaRUQgYWNjZXNzICh3aGljaCBpcyBtZWFu aW5nbGVzcyBvbiBhCj4gVlJBTSBidWZmZXIgYW55d2F5cykuIFdoaWxlIHdlJ3JlIGF0IGl0LCBh ZGQgc29tZSBmbHVzaGVzIGZvciBWQk8gZGF0YS4KPgo+IE1vdmluZyB0aGUgdmVydGV4IGJ1ZmZl ciBmcm9tIFZSQU0gdG8gR0FSVCBtYWtlcyBnbHhnZWFycyB3b3JrIGZ1bGx5Cj4gd2l0aCBOVjMw X1NXVE5MPTEuIFRoZSBvdGhlciBjaGFuZ2VzIGp1c3Qgc2VlbSBsaWtlIGEgZ29vZCBpZGVhLiBJ J20gbm90Cj4gc3VyZSAqd2h5KiBtb3ZpbmcgdGhlIGJ1ZmZlciBmcm9tIFZSQU0gbWFrZXMgaXQg d29yay4uLiBwZXJoYXBzCj4gc29tZXRoaW5nIGRvZXNuJ3QgZ2V0IGZsdXNoZWQgaW4gdGltZT8g SG93ZXZlciB0aGlzIGlzIGEgc2luZ2xlIHVzZSBieQo+IHRoZSBHUFUgYnVmZmVyLCBzbyBTVFJF QU0gc2VlbXMgbGlrZSB0aGUgY29ycmVjdCB1c2FnZSBzZW1hbnRpYyBmb3IgaXQuCgppJ20gbm90 IHJlYWxseSBoYXBweSBtb3ZpbmcgdGhpbmdzIHRvIGdhcnQgYW5kIGRvbid0IHNlZSB3aHkgdGhp cyAKcmVzb2x2ZXMgdGhlIGlzc3VlIGJ1dCBncmFudGVkIGlmIGl0IHdvcmtzIG91dCA6LSkKClJl dmlld2VkLWJ5OiBUb2JpYXMgS2xhdXNtYW5uIDx0b2JpYXMuam9oYW5uZXMua2xhdXNtYW5uQG1u aS50aG0uZGU+Cgo+IFNpZ25lZC1vZmYtYnk6IElsaWEgTWlya2luIDxpbWlya2luQGFsdW0ubWl0 LmVkdT4KPiBDYzogIjEwLjUgMTAuNiIgPG1lc2Etc3RhYmxlQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zz4KPiAtLS0KPiAgIHNyYy9nYWxsaXVtL2RyaXZlcnMvbm91dmVhdS9udjMwL252MzBfZHJhdy5j IHwgMzAgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDIz IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvc3JjL2dhbGxp dW0vZHJpdmVycy9ub3V2ZWF1L252MzAvbnYzMF9kcmF3LmMgYi9zcmMvZ2FsbGl1bS9kcml2ZXJz L25vdXZlYXUvbnYzMC9udjMwX2RyYXcuYwo+IGluZGV4IDZhMGQwNmYuLmE2ODExMzUgMTAwNjQ0 Cj4gLS0tIGEvc3JjL2dhbGxpdW0vZHJpdmVycy9ub3V2ZWF1L252MzAvbnYzMF9kcmF3LmMKPiAr KysgYi9zcmMvZ2FsbGl1bS9kcml2ZXJzL25vdXZlYXUvbnYzMC9udjMwX2RyYXcuYwo+IEBAIC03 MSwxMiArNzEsMTIgQEAgbnYzMF9yZW5kZXJfYWxsb2NhdGVfdmVydGljZXMoc3RydWN0IHZidWZf cmVuZGVyICpyZW5kZXIsCj4gICAgICBzdHJ1Y3QgbnYzMF9yZW5kZXIgKnIgPSBudjMwX3JlbmRl cihyZW5kZXIpOwo+ICAgICAgc3RydWN0IG52MzBfY29udGV4dCAqbnYzMCA9IHItPm52MzA7Cj4g ICAKPiAtICAgci0+bGVuZ3RoID0gdmVydGV4X3NpemUgKiBucl92ZXJ0aWNlczsKPiArICAgci0+ bGVuZ3RoID0gKHVpbnQzMl90KXZlcnRleF9zaXplICogKHVpbnQzMl90KW5yX3ZlcnRpY2VzOwo+ ICAgCj4gICAgICBpZiAoci0+b2Zmc2V0ICsgci0+bGVuZ3RoID49IHJlbmRlci0+bWF4X3ZlcnRl eF9idWZmZXJfYnl0ZXMpIHsKPiAgICAgICAgIHBpcGVfcmVzb3VyY2VfcmVmZXJlbmNlKCZyLT5i dWZmZXIsIE5VTEwpOwo+ICAgICAgICAgci0+YnVmZmVyID0gcGlwZV9idWZmZXJfY3JlYXRlKCZu djMwLT5zY3JlZW4tPmJhc2UuYmFzZSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFBJUEVfQklORF9WRVJURVhfQlVGRkVSLCAwLAo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgUElQRV9CSU5EX1ZFUlRFWF9CVUZGRVIsIFBJUEVfVVNBR0VfU1RS RUFNLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJlbmRlci0+bWF4 X3ZlcnRleF9idWZmZXJfYnl0ZXMpOwo+ICAgICAgICAgaWYgKCFyLT5idWZmZXIpCj4gICAgICAg ICAgICByZXR1cm4gRkFMU0U7Cj4gQEAgLTkxLDEwICs5MSwxNCBAQCBzdGF0aWMgdm9pZCAqCj4g ICBudjMwX3JlbmRlcl9tYXBfdmVydGljZXMoc3RydWN0IHZidWZfcmVuZGVyICpyZW5kZXIpCj4g ICB7Cj4gICAgICBzdHJ1Y3QgbnYzMF9yZW5kZXIgKnIgPSBudjMwX3JlbmRlcihyZW5kZXIpOwo+ IC0gICBjaGFyICptYXAgPSBwaXBlX2J1ZmZlcl9tYXAoJnItPm52MzAtPmJhc2UucGlwZSwgci0+ YnVmZmVyLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUElQRV9UUkFOU0ZFUl9X UklURSB8Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBQSVBFX1RSQU5TRkVSX1VO U1lOQ0hST05JWkVELCAmci0+dHJhbnNmZXIpOwo+IC0gICByZXR1cm4gbWFwICsgci0+b2Zmc2V0 Owo+ICsgICBjaGFyICptYXAgPSBwaXBlX2J1ZmZlcl9tYXBfcmFuZ2UoCj4gKyAgICAgICAgICZy LT5udjMwLT5iYXNlLnBpcGUsIHItPmJ1ZmZlciwKPiArICAgICAgICAgci0+b2Zmc2V0LCByLT5s ZW5ndGgsCj4gKyAgICAgICAgIFBJUEVfVFJBTlNGRVJfV1JJVEUgfAo+ICsgICAgICAgICBQSVBF X1RSQU5TRkVSX0RJU0NBUkRfUkFOR0UsCj4gKyAgICAgICAgICZyLT50cmFuc2Zlcik7Cj4gKyAg IGFzc2VydChtYXApOwo+ICsgICByZXR1cm4gbWFwOwo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9p ZAo+IEBAIC0xMjcsMTIgKzEzMSwxOCBAQCBudjMwX3JlbmRlcl9kcmF3X2VsZW1lbnRzKHN0cnVj dCB2YnVmX3JlbmRlciAqcmVuZGVyLAo+ICAgICAgZm9yIChpID0gMDsgaSA8IHItPnZlcnRleF9p bmZvLm51bV9hdHRyaWJzOyBpKyspIHsKPiAgICAgICAgIFBVU0hfUkVTUkMocHVzaCwgTlYzMF8z RChWVFhCVUYoaSkpLCBCVUZDVFhfVlRYVE1QLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICBu djA0X3Jlc291cmNlKHItPmJ1ZmZlciksIHItPm9mZnNldCArIHItPnZ0eHB0cltpXSwKPiAtICAg ICAgICAgICAgICAgICAgICAgICBOT1VWRUFVX0JPX0xPVyB8IE5PVVZFQVVfQk9fUkQsIDAsIDAp Owo+ICsgICAgICAgICAgICAgICAgICAgICAgIE5PVVZFQVVfQk9fTE9XIHwgTk9VVkVBVV9CT19S RCwgMCwgTlYzMF8zRF9WVFhCVUZfRE1BMSk7Cj4gICAgICB9Cj4gICAKPiAgICAgIGlmICghbnYz MF9zdGF0ZV92YWxpZGF0ZShudjMwLCB+MCwgRkFMU0UpKQo+ICAgICAgICAgcmV0dXJuOwo+ICAg Cj4gKyAgIGlmIChudjMwLT5iYXNlLnZib19kaXJ0eSkgewo+ICsgICAgICBCRUdJTl9OVjA0KHB1 c2gsIE5WMzBfM0QoVlRYX0NBQ0hFX0lOVkFMSURBVEVfMTcxMCksIDEpOwo+ICsgICAgICBQVVNI X0RBVEEgKHB1c2gsIDApOwo+ICsgICAgICBudjMwLT5iYXNlLnZib19kaXJ0eSA9IEZBTFNFOwo+ ICsgICB9Cj4gKwo+ICAgICAgQkVHSU5fTlYwNChwdXNoLCBOVjMwXzNEKFZFUlRFWF9CRUdJTl9F TkQpLCAxKTsKPiAgICAgIFBVU0hfREFUQSAocHVzaCwgci0+cHJpbSk7Cj4gICAKPiBAQCAtMTc4 LDYgKzE4OCwxMiBAQCBudjMwX3JlbmRlcl9kcmF3X2FycmF5cyhzdHJ1Y3QgdmJ1Zl9yZW5kZXIg KnJlbmRlciwgdW5zaWduZWQgc3RhcnQsIHVpbnQgbnIpCj4gICAgICBpZiAoIW52MzBfc3RhdGVf dmFsaWRhdGUobnYzMCwgfjAsIEZBTFNFKSkKPiAgICAgICAgIHJldHVybjsKPiAgIAo+ICsgICBp ZiAobnYzMC0+YmFzZS52Ym9fZGlydHkpIHsKPiArICAgICAgQkVHSU5fTlYwNChwdXNoLCBOVjMw XzNEKFZUWF9DQUNIRV9JTlZBTElEQVRFXzE3MTApLCAxKTsKPiArICAgICAgUFVTSF9EQVRBIChw dXNoLCAwKTsKPiArICAgICAgbnYzMC0+YmFzZS52Ym9fZGlydHkgPSBGQUxTRTsKPiArICAgfQo+ ICsKPiAgICAgIEJFR0lOX05WMDQocHVzaCwgTlYzMF8zRChWRVJURVhfQkVHSU5fRU5EKSwgMSk7 Cj4gICAgICBQVVNIX0RBVEEgKHB1c2gsIHItPnByaW0pOwo+ICAgCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOb3V2ZWF1IG1haWxpbmcgbGlzdApOb3V2 ZWF1QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vbm91dmVhdQo=