From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: [PATCH v3] i386: Introduce ARAT CPU feature Date: Tue, 26 May 2015 06:35:45 +0200 Message-ID: <5563F821.7080202@web.de> References: <5561EB59.5000407@web.de> <5563225B.60200@redhat.com> <55632C7A.8010107@web.de> <55632EAE.9030508@redhat.com> <20150525180334.GQ17796@thinpad.lan.raisama.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PrIkD5dPa3m6j7AhxROTtupp74HWXkwsO" Cc: qemu-devel , kvm To: Eduardo Habkost , Paolo Bonzini Return-path: Received: from [212.227.15.14] ([212.227.15.14]:62919 "EHLO mout.web.de" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751142AbbEZEgb (ORCPT ); Tue, 26 May 2015 00:36:31 -0400 In-Reply-To: <20150525180334.GQ17796@thinpad.lan.raisama.net> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PrIkD5dPa3m6j7AhxROTtupp74HWXkwsO Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable From: Jan Kiszka ARAT signals that the APIC timer does not stop in power saving states. As our APICs are emulated, it's fine to expose this feature to guests, at least when asking for KVM host features or with CPU types that include the flag. The exact model number that introduced the feature is not known, but reports can be found that it's at least available since Sandy Bridge. Signed-off-by: Jan Kiszka --- Changes in v4: - followed suggestions by Eduardo, now using PC_COMPAT_2_3 define hw/i386/pc_piix.c | 4 ++++ hw/i386/pc_q35.c | 4 ++++ include/hw/i386/pc.h | 8 ++++++++ target-i386/cpu.c | 33 ++++++++++++++++++++++++++++++++- target-i386/cpu.h | 3 +++ target-i386/kvm.c | 2 ++ 6 files changed, 53 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 212e263..b675d2c 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -543,6 +543,10 @@ static QEMUMachine pc_i440fx_machine_v2_3 =3D { PC_I440FX_2_3_MACHINE_OPTIONS, .name =3D "pc-i440fx-2.3", .init =3D pc_init_pci_2_3, + .compat_props =3D (GlobalProperty[]) { + PC_COMPAT_2_3, + { /* end of list */ } + }, }; =20 #define PC_I440FX_2_2_MACHINE_OPTIONS PC_I440FX_2_3_MACHINE_OPTIONS diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index e67f2de..38c3cf2 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -439,6 +439,10 @@ static QEMUMachine pc_q35_machine_v2_3 =3D { PC_Q35_2_3_MACHINE_OPTIONS, .name =3D "pc-q35-2.3", .init =3D pc_q35_init_2_3, + .compat_props =3D (GlobalProperty[]) { + PC_COMPAT_2_3, + { /* end of list */ } + }, }; =20 #define PC_Q35_2_2_MACHINE_OPTIONS PC_Q35_2_3_MACHINE_OPTIONS diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 1b35168..365af62 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -295,7 +295,15 @@ int e820_add_entry(uint64_t, uint64_t, uint32_t); int e820_get_num_entries(void); bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); =20 +#define PC_COMPAT_2_3 \ + {\ + .driver =3D TYPE_X86_CPU,\ + .property =3D "arat",\ + .value =3D "off",\ + } + #define PC_COMPAT_2_0 \ + PC_COMPAT_2_3, \ HW_COMPAT_2_1, \ {\ .driver =3D "virtio-scsi-pci",\ diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e38943e..c273d24 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -284,6 +284,17 @@ static const char *cpuid_xsave_feature_name[] =3D { NULL, NULL, NULL, NULL, }; =20 +static const char *cpuid_6_feature_name[] =3D { + NULL, NULL, "arat", NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, + NULL, NULL, NULL, NULL, +}; + #define I486_FEATURES (CPUID_FP87 | CPUID_VME | CPUID_PSE) #define PENTIUM_FEATURES (I486_FEATURES | CPUID_DE | CPUID_TSC | \ CPUID_MSR | CPUID_MCE | CPUID_CX8 | CPUID_MMX | CPUID_APIC) @@ -339,6 +350,7 @@ static const char *cpuid_xsave_feature_name[] =3D { CPUID_7_0_EBX_ERMS, CPUID_7_0_EBX_INVPCID, CPUID_7_0_EBX_RTM, CPUID_7_0_EBX_RDSEED */ #define TCG_APM_FEATURES 0 +#define TCG_6_EAX_FEATURES CPUID_6_EAX_ARAT =20 =20 typedef struct FeatureWordInfo { @@ -408,6 +420,11 @@ static FeatureWordInfo feature_word_info[FEATURE_WOR= DS] =3D { .cpuid_reg =3D R_EAX, .tcg_features =3D 0, }, + [FEAT_6_EAX] =3D { + .feat_names =3D cpuid_6_feature_name, + .cpuid_eax =3D 6, .cpuid_reg =3D R_EAX, + .tcg_features =3D TCG_6_EAX_FEATURES, + }, }; =20 typedef struct X86RegisterInfo32 { @@ -1001,6 +1018,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX, .features[FEAT_8000_0001_ECX] =3D CPUID_EXT3_LAHF_LM, + .features[FEAT_6_EAX] =3D + CPUID_6_EAX_ARAT, .xlevel =3D 0x8000000A, .model_id =3D "Westmere E56xx/L56xx/X56xx (Nehalem-C)", }, @@ -1030,6 +1049,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { CPUID_EXT3_LAHF_LM, .features[FEAT_XSAVE] =3D CPUID_XSAVE_XSAVEOPT, + .features[FEAT_6_EAX] =3D + CPUID_6_EAX_ARAT, .xlevel =3D 0x8000000A, .model_id =3D "Intel Xeon E312xx (Sandy Bridge)", }, @@ -1062,6 +1083,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { CPUID_EXT3_LAHF_LM, .features[FEAT_XSAVE] =3D CPUID_XSAVE_XSAVEOPT, + .features[FEAT_6_EAX] =3D + CPUID_6_EAX_ARAT, .xlevel =3D 0x8000000A, .model_id =3D "Intel Xeon E3-12xx v2 (Ivy Bridge)", }, @@ -1096,6 +1119,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ERMS | CPUID_7_0_EBX_INVP= CID, .features[FEAT_XSAVE] =3D CPUID_XSAVE_XSAVEOPT, + .features[FEAT_6_EAX] =3D + CPUID_6_EAX_ARAT, .xlevel =3D 0x8000000A, .model_id =3D "Intel Core Processor (Haswell, no TSX)", }, { @@ -1130,6 +1155,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { CPUID_7_0_EBX_RTM, .features[FEAT_XSAVE] =3D CPUID_XSAVE_XSAVEOPT, + .features[FEAT_6_EAX] =3D + CPUID_6_EAX_ARAT, .xlevel =3D 0x8000000A, .model_id =3D "Intel Core Processor (Haswell)", }, @@ -1166,6 +1193,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { CPUID_7_0_EBX_SMAP, .features[FEAT_XSAVE] =3D CPUID_XSAVE_XSAVEOPT, + .features[FEAT_6_EAX] =3D + CPUID_6_EAX_ARAT, .xlevel =3D 0x8000000A, .model_id =3D "Intel Core Processor (Broadwell, no TSX)", }, @@ -1202,6 +1231,8 @@ static X86CPUDefinition builtin_x86_defs[] =3D { CPUID_7_0_EBX_SMAP, .features[FEAT_XSAVE] =3D CPUID_XSAVE_XSAVEOPT, + .features[FEAT_6_EAX] =3D + CPUID_6_EAX_ARAT, .xlevel =3D 0x8000000A, .model_id =3D "Intel Core Processor (Broadwell)", }, @@ -2358,7 +2389,7 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index= , uint32_t count, break; case 6: /* Thermal and Power Leaf */ - *eax =3D 0; + *eax =3D env->features[FEAT_6_EAX]; *ebx =3D 0; *ecx =3D 0; *edx =3D 0; diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 4ee12ca..800158e 100644 --- a/target-i386/cpu.h +++ b/target-i386/cpu.h @@ -412,6 +412,7 @@ typedef enum FeatureWord { FEAT_KVM, /* CPUID[4000_0001].EAX (KVM_CPUID_FEATURES) */ FEAT_SVM, /* CPUID[8000_000A].EDX */ FEAT_XSAVE, /* CPUID[EAX=3D0xd,ECX=3D1].EAX */ + FEAT_6_EAX, /* CPUID[6].EAX */ FEATURE_WORDS, } FeatureWord; =20 @@ -577,6 +578,8 @@ typedef uint32_t FeatureWordArray[FEATURE_WORDS]; #define CPUID_XSAVE_XGETBV1 (1U << 2) #define CPUID_XSAVE_XSAVES (1U << 3) =20 +#define CPUID_6_EAX_ARAT (1U << 2) + /* CPUID[0x80000007].EDX flags: */ #define CPUID_APM_INVTSC (1U << 8) =20 diff --git a/target-i386/kvm.c b/target-i386/kvm.c index a26d25a..b786359 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -233,6 +233,8 @@ uint32_t kvm_arch_get_supported_cpuid(KVMState *s, ui= nt32_t function, if (!kvm_irqchip_in_kernel()) { ret &=3D ~CPUID_EXT_X2APIC; } + } else if (function =3D=3D 6 && reg =3D=3D R_EAX) { + ret |=3D CPUID_6_EAX_ARAT; /* safe to allow because of emulated = APIC */ } else if (function =3D=3D 0x80000001 && reg =3D=3D R_EDX) { /* On Intel, kvm returns cpuid according to the Intel spec, * so add missing bits according to the AMD spec: --=20 2.1.4 --PrIkD5dPa3m6j7AhxROTtupp74HWXkwsO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlVj+CIACgkQitSsb3rl5xSErACcCoFVxmCs8LRHYQEvyHO1xQK8 WlMAniXV2BgP+tO9gE0Ymh6jMCCYyuaR =ICKj -----END PGP SIGNATURE----- --PrIkD5dPa3m6j7AhxROTtupp74HWXkwsO--