From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42042) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx89O-00080O-63 for qemu-devel@nongnu.org; Tue, 26 May 2015 02:15:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yx89J-0002XU-6u for qemu-devel@nongnu.org; Tue, 26 May 2015 02:15:42 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:44838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yx89I-0002XQ-El for qemu-devel@nongnu.org; Tue, 26 May 2015 02:15:37 -0400 Message-ID: <55640F74.4000903@huawei.com> Date: Tue, 26 May 2015 14:15:16 +0800 From: Shannon Zhao MIME-Version: 1.0 References: <1432568042-19553-1-git-send-email-marcel@redhat.com> <1432568042-19553-6-git-send-email-marcel@redhat.com> In-Reply-To: <1432568042-19553-6-git-send-email-marcel@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V7 05/24] acpi: add aml_shiftleft() term List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mst@redhat.com On 2015/5/25 23:33, Marcel Apfelbaum wrote: > Add encoding for ACPI DefShiftLeft Opcode. > > Reviewed-by: Igor Mammedov > Signed-off-by: Marcel Apfelbaum Reviewed-by: Shannon Zhao > --- > hw/acpi/aml-build.c | 10 ++++++++++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c > index 82a3fc9..4d45610 100644 > --- a/hw/acpi/aml-build.c > +++ b/hw/acpi/aml-build.c > @@ -464,6 +464,16 @@ Aml *aml_or(Aml *arg1, Aml *arg2) > return var; > } > > +/* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefShiftLeft */ > +Aml *aml_shiftleft(Aml *arg1, Aml *count) > +{ > + Aml *var = aml_opcode(0x79 /* ShiftLeftOp */); > + aml_append(var, arg1); > + aml_append(var, count); > + build_append_byte(var->buf, 0x00); /* NullNameOp */ > + return var; > +} > + > /* ACPI 1.0b: 16.2.5.4 Type 2 Opcodes Encoding: DefLLess */ > Aml *aml_lless(Aml *arg1, Aml *arg2) > { > diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h > index fd3f58c..6391331 100644 > --- a/include/hw/acpi/aml-build.h > +++ b/include/hw/acpi/aml-build.h > @@ -164,6 +164,7 @@ Aml *aml_arg(int pos); > Aml *aml_store(Aml *val, Aml *target); > Aml *aml_and(Aml *arg1, Aml *arg2); > Aml *aml_or(Aml *arg1, Aml *arg2); > +Aml *aml_shiftleft(Aml *arg1, Aml *count); > Aml *aml_lless(Aml *arg1, Aml *arg2); > Aml *aml_add(Aml *arg1, Aml *arg2); > Aml *aml_index(Aml *arg1, Aml *idx); > -- Shannon