From: John Crispin <blogic@openwrt.org>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-gpio@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH 1/2] gpio-stp-xway: Fix enabling the highest bit of the PHY LEDs
Date: Tue, 26 May 2015 08:54:01 +0200 [thread overview]
Message-ID: <55641889.4010705@openwrt.org> (raw)
In-Reply-To: <1432586391-27634-1-git-send-email-martin.blumenstingl@googlemail.com>
On 25/05/2015 22:39, Martin Blumenstingl wrote:
> 0x3 only masks two bits, but three bits have to be allowed. This fixes
> GPHY0 LED2 (which is the highest bit of phy2) on my board.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Acked-by: John Crispin <blogic@openwrt.org>
> ---
> drivers/gpio/gpio-stp-xway.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-stp-xway.c b/drivers/gpio/gpio-stp-xway.c
> index 202361e..6d4148f 100644
> --- a/drivers/gpio/gpio-stp-xway.c
> +++ b/drivers/gpio/gpio-stp-xway.c
> @@ -58,7 +58,7 @@
> #define XWAY_STP_ADSL_MASK 0x3
>
> /* 2 groups of 3 bits can be driven by the phys */
> -#define XWAY_STP_PHY_MASK 0x3
> +#define XWAY_STP_PHY_MASK 0x7
> #define XWAY_STP_PHY1_SHIFT 27
> #define XWAY_STP_PHY2_SHIFT 15
>
>
next prev parent reply other threads:[~2015-05-26 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 20:39 [PATCH 1/2] gpio-stp-xway: Fix enabling the highest bit of the PHY LEDs Martin Blumenstingl
2015-05-25 20:39 ` [PATCH 2/2] gpio-stp-xway: Use the of_property_read_u32 helper Martin Blumenstingl
2015-05-26 6:56 ` John Crispin
2015-05-26 21:12 ` [PATCHv2 " Martin Blumenstingl
2015-06-01 14:59 ` Linus Walleij
2015-05-26 6:54 ` John Crispin [this message]
2015-06-01 14:44 ` [PATCH 1/2] gpio-stp-xway: Fix enabling the highest bit of the PHY LEDs Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55641889.4010705@openwrt.org \
--to=blogic@openwrt.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.