Re: [PATCH-v2 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member

[Hannes Reinecke <hare@suse.de>]

On 05/26/2015 08:57 AM, Nicholas A. Bellinger wrote:
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> 
> Hi all,
> 
> Here is v2 series with HCH's recent changes to go ahead and drop
> all se_port + t10_alua_tg_pt_gp_member usage within target-core in
> favor of direct se_lun pointer dereference.
> 
> This includes the original patch + minor fixes, along with two other
> improvements for killing off se_lun->lun_sep_lock via RCU pointer
> access, and converting the remaining se_lun->lun_active busy-wait
> special cases to existing percpu se_lun->lun_ref access.
> 
> Also included in the series is a recently discussed change to go
> ahead and drop an unnecessary core_tpg_register() parameter, and
> all associated target_core_fabric_ops forward declartions within
> fabric driver code.
> 
> The changes since -v1 include:
> 
>   - Move ->lun_se_dev assignments under se_device->se_port_lock
>   - All proper call_rcu() in backend drivers to allow for read-side
>     critical se_device RCU to complete
>   - Add se_device->hba_index to clean up RCU dereferences within
>     scsi_port_show_attr_inst() + scsi_tgt_port_show_attr_inst()
>   - Add various rcu_dereference and lockless_dereference RCU notation
> 
> Please review.
> 
> --nab
> 
For the whole series:

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)