From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h
Date: Tue, 26 May 2015 13:39:42 +0200 [thread overview]
Message-ID: <55645B7E.3000107@denx.de> (raw)
In-Reply-To: <555F7302.1060609@web.de>
Hi Soeren,
On 22/05/2015 20:18, Soeren Moch wrote:
>> All boards define CONFIG_MX6, CONFIG_DISPLAY_BOARDINFO,
>> CONFIG_DISPLAY_CPUINFO
>> and CONFIG_SYS_GENERIC_BOARD so define them in mx6_common
>>
>> Signed-off-by: Peter Robinson<pbrobinson@gmail.com>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> Some boards defineCONFIG_DISPLAY_BOARDINFO_LATE (instead of
> CONFIG_DISPLAY_BOARDINFO) to also see this info on HDMI.
>
> So please add CONFIG_DISPLAY_BOARDINFO_LATE to mx6_common.h
>
> Sorry, I missed this in the last review round.
As far as I can see, there are only two boards : gw_ventana and tbs2910.
CONFIG_DISPLAY_BOARDINFO_LATE enables show_board_info(), and this is not
weak, printing twice if we have both CONFIG_DISPLAY_BOARDINFO_LATE and
CONFIG_DISPLAY_BOARDINFO. I would suggest that we add
#undef CONFIG_DISPLAY_BOARDINFO
#define CONFIG_DISPLAY_BOARDINFO_LATE
to gw_ventana.h and tbs2910.h after applying this series.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2015-05-26 11:39 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 16:30 [U-Boot] [PATCH 0/10 v3] i.MX6: move duplicated options to mx6_common to standardise mx6 config Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 01/10] novena: standardise mx6_common.h include Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 02/10] imx6: move all standard includes to mx6_common.h Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options " Peter Robinson
2015-05-22 18:18 ` Soeren Moch
2015-05-26 11:39 ` Stefano Babic [this message]
2015-05-26 12:10 ` Soeren Moch
2015-05-29 18:02 ` Soeren Moch
2015-05-22 16:30 ` [U-Boot] [PATCH 04/10] imx6: move standard ATAG configs " Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 05/10] imx6: move MXC_GPIO define " Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 06/10] imx6: centralise common boot options in mx6_common.h Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 07/10] imx6: move generic miscellaneous and overwrite options Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 08/10] imx6: standardise filesystem and boot options Peter Robinson
2015-05-22 18:48 ` Soeren Moch
2015-05-22 23:06 ` Peter Robinson
2015-05-23 4:35 ` Soeren Moch
2015-05-22 16:30 ` [U-Boot] [PATCH 09/10] imx6: generic MMC config options to mx6_common Peter Robinson
2015-05-22 16:30 ` [U-Boot] [PATCH 10/10] mx6: standardise CONFIG_CMD_CACHE Peter Robinson
2015-05-26 12:11 ` [U-Boot] [PATCH 0/10 v3] i.MX6: move duplicated options to mx6_common to standardise mx6 config Stefano Babic
2015-05-26 13:23 ` Peter Robinson
2015-05-26 14:06 ` Stefano Babic
2015-05-27 1:45 ` Fabio Estevam
2015-05-27 2:08 ` Fabio Estevam
2015-05-27 6:26 ` Stefano Babic
-- strict thread matches above, loose matches on Subject: below --
2015-05-11 16:22 [U-Boot] [PATCH 0/10 v2] " Peter Robinson
2015-05-11 16:22 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h Peter Robinson
2015-05-12 8:40 ` Markus Niebel
2015-05-12 10:51 ` Tom Rini
2015-05-12 11:12 ` Markus Niebel
2015-05-15 11:30 ` Stefano Babic
2015-05-11 11:23 [U-Boot] [PATCH 0/10] i.MX6: move duplicated options to mx6_common to standardise mx6 config Peter Robinson
2015-05-11 11:23 ` [U-Boot] [PATCH 03/10] imx6: move generic imx6 options to mx6_common.h Peter Robinson
2015-05-11 12:43 ` Tom Rini
2015-05-12 6:29 ` Markus Niebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55645B7E.3000107@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.