From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <556474C2.7020600@imgtec.com> Date: Tue, 26 May 2015 10:27:30 -0300 From: Ezequiel Garcia MIME-Version: 1.0 To: Jonathan Cameron , , Lars-Peter Clausen CC: Naidu Tellapati , James Hartley , Subject: Re: [PATCH 5/5] iio: adc: cc10001: Power-up the ADC at probe time when used remotely References: <1431033842-1149-1-git-send-email-ezequiel.garcia@imgtec.com> <554CBD24.3060205@kernel.org> In-Reply-To: <554CBD24.3060205@kernel.org> Content-Type: text/plain; charset="windows-1252" List-ID: On 05/08/2015 10:41 AM, Jonathan Cameron wrote: > On 07/05/15 17:24, Ezequiel Garcia wrote: >> From: Naidu Tellapati >> >> The ADC is typically shared with remote CPUs not running Linux. >> However, there is only one register to power-up/power-down. Remote CPUs >> aren't able to power-up the ADC, and rely in Linux doing it instead. >> >> This commit uses the adc-reserved-channels devicetree property to >> distinguish shared usage. In this case, the ADC is powered up at >> probe time. >> >> If the ADC is used only by the CPU running Linux, power-up/down >> at runtime, only when neeeded. >> >> Signed-off-by: Naidu Tellapati >> Signed-off-by: Ezequiel Garcia > Seems sensible to me, but as you observe it's not a fix as such, so > will hold this until the other patches have propagated through to > the togreg tree. > > Feel free to remind me if I seem to have forgotten! > Ping. Thanks! -- Ezequiel