From: Peter Hurley <peter@hurleysoftware.com>
To: Arnd Bergmann <arnd@arndb.de>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tfiga@google.com,
Marek Szyprowski <m.szyprowski@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH] serial: samsung: only use earlycon for console
Date: Tue, 26 May 2015 10:00:30 -0400 [thread overview]
Message-ID: <55647C7E.6010907@hurleysoftware.com> (raw)
In-Reply-To: <3397068.2Doeo7zeZ1@wuerfel>
On 05/19/2015 04:26 PM, Arnd Bergmann wrote:
> A configuration that enables earlycon but not the core console
> code causes a link error:
>
> drivers/built-in.o: In function `setup_earlycon':
> drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
>
> That error can be triggered by the newly added samsung earlycon support,
> which is missing a 'select' statement.
>
> As suggested by Peter Hurley, solves the problem by moving the
> 'select SERIAL_EARLYCON' statement to the samsung console driver
> option, as it is done by all other console drivers.
Thanks.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: samsung: only use earlycon for console
Date: Tue, 26 May 2015 10:00:30 -0400 [thread overview]
Message-ID: <55647C7E.6010907@hurleysoftware.com> (raw)
In-Reply-To: <3397068.2Doeo7zeZ1@wuerfel>
On 05/19/2015 04:26 PM, Arnd Bergmann wrote:
> A configuration that enables earlycon but not the core console
> code causes a link error:
>
> drivers/built-in.o: In function `setup_earlycon':
> drivers/tty/serial/earlycon.c:70: undefined reference to `uart_parse_earlycon'
>
> That error can be triggered by the newly added samsung earlycon support,
> which is missing a 'select' statement.
>
> As suggested by Peter Hurley, solves the problem by moving the
> 'select SERIAL_EARLYCON' statement to the samsung console driver
> option, as it is done by all other console drivers.
Thanks.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
next prev parent reply other threads:[~2015-05-26 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 20:26 [PATCH] serial: samsung: only use earlycon for console Arnd Bergmann
2015-05-19 20:26 ` Arnd Bergmann
2015-05-26 14:00 ` Peter Hurley [this message]
2015-05-26 14:00 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55647C7E.6010907@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=alim.akhtar@samsung.com \
--cc=arnd@arndb.de \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=tfiga@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.