From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty()
Date: Tue, 26 May 2015 17:51:51 +0200 [thread overview]
Message-ID: <55649697.5000100@redhat.com> (raw)
In-Reply-To: <w51a8wrgwwj.fsf@maestria.local.igalia.com>
On 26.05.2015 17:51, Alberto Garcia wrote:
> On Tue 26 May 2015 05:39:12 PM CEST, Max Reitz <mreitz@redhat.com> wrote:
>
>>> After having emptied the cache, the data in the cache tables is no
>>> longer useful, so we can tell the kernel that we are done with it. In
>>> Linux this frees the resources associated with it.
>> Looks good, but by applying the same logic, you could do the same call
>> in qcow2_cache_create(). So what about it? :-)
> But after qcow2_cache_create() the memory is still unused so this
> doesn't have any affect.
That was too easy. Right.
Reviewed-by: Max Reitz <mreitz@redhat.com>
>> Also note that bdrv_commit() is used only by the HMP commit operation,
>> not by QMP commit.
> Thanks, I should probably clarify that in the commit message.
>
> Berto
next prev parent reply other threads:[~2015-05-26 15:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 16:48 [Qemu-devel] [PATCH 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-18 16:48 ` [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Alberto Garcia
2015-05-26 15:39 ` Max Reitz
2015-05-26 15:51 ` Alberto Garcia
2015-05-26 15:51 ` Max Reitz [this message]
2015-05-18 16:48 ` [Qemu-devel] [PATCH 2/3] qcow2: add option to clean unused cache entries after some time Alberto Garcia
2015-05-26 16:07 ` Max Reitz
2015-05-18 16:48 ` [Qemu-devel] [PATCH 3/3] qcow2: reorder fields in Qcow2CachedTable to reduce padding Alberto Garcia
2015-05-26 16:10 ` Max Reitz
2015-05-26 16:12 ` Eric Blake
2015-05-26 16:14 ` Max Reitz
2015-05-26 16:20 ` Alberto Garcia
2015-05-26 16:13 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2015-05-26 17:14 [Qemu-devel] [PATCH v2 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-26 17:14 ` [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Alberto Garcia
2015-05-27 9:46 [Qemu-devel] [PATCH v3 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-27 9:46 ` [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Alberto Garcia
2015-05-29 9:24 [Qemu-devel] [PATCH v4 0/3] Clean unused entries in the qcow2 L2/refcount cache Alberto Garcia
2015-05-29 9:24 ` [Qemu-devel] [PATCH 1/3] qcow2: mark the memory as no longer needed after qcow2_cache_empty() Alberto Garcia
2015-06-02 10:05 ` Kevin Wolf
2015-06-02 10:50 ` Alberto Garcia
2015-06-02 10:56 ` Kevin Wolf
2015-06-02 11:08 ` Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55649697.5000100@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.