All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Thompson <daniel.thompson@linaro.org>
To: Damian Hobson-Garcia <dhobsong@igel.co.jp>,
	dri-devel@lists.freedesktop.org
Cc: robdclark@gmail.com, airlied@linux.ie, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 v3.18-rc4 1/4] drm: prime: Honour O_RDWR during prime-handle-to-fd
Date: Wed, 27 May 2015 08:48:45 +0100	[thread overview]
Message-ID: <556576DD.1090201@linaro.org> (raw)
In-Reply-To: <556536D8.7070104@igel.co.jp>

On 27/05/15 04:15, Damian Hobson-Garcia wrote:
> Hello,
>> On Wed, Nov 12, 2014 at 6:38 AM, Daniel Thompson <daniel.thompson@linaro.org> wrote:
>>> Currently DRM_IOCTL_PRIME_HANDLE_TO_FD rejects all flags except
>>> (DRM|O)_CLOEXEC making it hard for the userspace to generate a file
>>> descriptor that can be used by mmap().
>>>
>>> It is easy to relax the restriction and allow read/write permissions.
>>> This should be safe because the flags are seldom touched by drm; mostly
>>> they are passed verbatim to dma_buf calls.
>>>
>>> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
>>
>> Reviewed-by: Rob Clark <robdclark@gmail.com>
>
> It's a little bit old by now, but I'm wondering if someone call tell me
> whether this patch is likely to be merged sometime, or has it been
> (should it be?) abandoned.

For me, this code remains useful and it would be good to merge it.

I accidentally removed the whole patchset from my 
"keep-resending-these-patches" when patch 3 went upstream... I'll rebase 
this when I get a  chance.


Daniel.


PS
Damn it all..., Rob may (or may not) remember my saying I had trouble 
getting the DRM GFX code to come up on my Android/IFC6410 port. Losing 
track of this patch would certainly explain it!

  reply	other threads:[~2015-05-27  7:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10 17:16 [PATCH v3.18-rc3] drm: msm: Allow exported dma-bufs to be mapped Daniel Thompson
2014-11-10 17:36 ` Rob Clark
2014-11-10 17:36   ` Rob Clark
2014-11-11 14:28   ` Daniel Thompson
2014-11-11 14:28     ` Daniel Thompson
2014-11-11 16:26     ` Rob Clark
2014-11-11 16:26       ` Rob Clark
2014-11-12  9:41       ` Benjamin Gaignard
2014-11-12  9:41         ` Benjamin Gaignard
2014-11-12  9:44         ` Daniel Thompson
2014-11-12  9:44           ` Daniel Thompson
2014-11-12 11:38 ` [PATCH v2 v3.18-rc4 0/4] drm: prime: " Daniel Thompson
2014-11-12 11:38   ` Daniel Thompson
2014-11-12 11:38   ` [PATCH v2 v3.18-rc4 1/4] drm: prime: Honour O_RDWR during prime-handle-to-fd Daniel Thompson
2014-11-12 11:38     ` Daniel Thompson
2014-11-12 14:41     ` Rob Clark
2014-11-12 14:41       ` Rob Clark
2015-05-27  3:15       ` Damian Hobson-Garcia
2015-05-27  7:48         ` Daniel Thompson [this message]
2014-11-12 11:38   ` [PATCH v2 v3.18-rc4 2/4] drm: prime: Document gem_prime_mmap Daniel Thompson
2014-11-12 11:38     ` Daniel Thompson
2014-11-12 14:11     ` Daniel Vetter
2014-11-12 14:11       ` Daniel Vetter
2014-11-12 14:42     ` Rob Clark
2014-11-12 14:42       ` Rob Clark
2014-11-12 11:38   ` [PATCH v2 v3.18-rc4 3/4] drm: msm: Allow exported dma-bufs to be mapped Daniel Thompson
2014-11-12 11:38     ` Daniel Thompson
2014-11-12 14:26     ` Rob Clark
2014-11-12 14:26       ` Rob Clark
2014-11-12 11:38   ` [PATCH v2 v3.18-rc4 4/4] drm: sti: Honour O_RDWR during prime-handle-to-fd Daniel Thompson
2014-11-12 11:38     ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556576DD.1090201@linaro.org \
    --to=daniel.thompson@linaro.org \
    --cc=airlied@linux.ie \
    --cc=dhobsong@igel.co.jp \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.