From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: question on "xen-blkback: enlarge the array size of blkback name" Date: Wed, 27 May 2015 10:28:40 +0100 Message-ID: <55658E48.5060409@citrix.com> References: <5565A0C5020000780007E1F1@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YxXtI-0001Qs-N2 for xen-devel@lists.xenproject.org; Wed, 27 May 2015 09:44:48 +0000 In-Reply-To: <5565A0C5020000780007E1F1@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , boby.chen@huawei.com Cc: xen-devel List-Id: xen-devel@lists.xenproject.org El 27/05/15 a les 9.47, Jan Beulich ha escrit: > Hello, > > looking at this once again now that it's upstream, I still can't see what > this is good for: The only use the produced string has is to be passed > to kthread_run(), i.e. ultimately to be stored in a task's ->comm. That, > however, continues to be limited to 16 characters, so > blkback.domid.xvd[a-z] being up to 18 characters I don't understand > how the change results in the full name being shown. What am I > missing? Right, I didn't realize there was a length limitation in task_struct. How did you manage to get it working Chentao? > Why aren't you instead shortening the string to e.g. > blkbk.domid.xvd[a-z] (which still is 16 characters, i.e. the last > character would still be chopped off for 5 digit domain IDs; perhaps > the first dot should then also be dropped). That sounds right. Roger.