Re: [Qemu-devel] [RFC PATCH 1/4] aio-posix: Introduce aio_set_io_event_notifier

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On 05/27/2015 01:19 AM, Fam Zheng wrote:
> This function will register the fd handler similar to
> aio_set_event_notifier, but the difference is the fd will only be polled
> in the outmost aio_poll.

s/outmost/outermost/
that will have a ripple effect throughout the patch series...

> 
> This is useful in some cases like device ioeventfd, where the handler
> typically processes a guest request, therefore nested aio_poll shouldn't
> include this.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  aio-posix.c         | 33 +++++++++++++++++++++++++++------
>  include/block/aio.h | 23 ++++++++++++++++++++---
>  2 files changed, 47 insertions(+), 9 deletions(-)
> 
> diff --git a/aio-posix.c b/aio-posix.c
> index 4abec38..05a0502 100644
> --- a/aio-posix.c
> +++ b/aio-posix.c
> @@ -24,6 +24,7 @@ struct AioHandler
>      IOHandler *io_read;
>      IOHandler *io_write;
>      int deleted;
> +    bool outmost;

...like here

But I'll probably let others do the technical review.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]