From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: imx: display message if no pcie link
Date: Wed, 27 May 2015 15:30:04 +0200 [thread overview]
Message-ID: <5565C6DC.8060609@denx.de> (raw)
In-Reply-To: <CAJ+vNU1XUtHoPwUUHSLQx-=PzOoxkSb7VB1Cp+Q0KhH2=XXyTA@mail.gmail.com>
Hi Tim,
On 27/05/2015 15:21, Tim Harvey wrote:
> On Fri, May 8, 2015 at 3:17 PM, Tim Harvey <tharvey@gateworks.com> wrote:
>> If CONFIG_PCI_SCAN_SHOW enabled then lets print a message of no link was
>> detected.
>>
>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>> ---
>> drivers/pci/pcie_imx.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/pcie_imx.c b/drivers/pci/pcie_imx.c
>> index fd7e4d4..ca485ba 100644
>> --- a/drivers/pci/pcie_imx.c
>> +++ b/drivers/pci/pcie_imx.c
>> @@ -588,7 +588,9 @@ static int imx_pcie_link_up(void)
>> udelay(10);
>> count++;
>> if (count >= 2000) {
>> - debug("phy link never came up\n");
>> +#ifdef CONFIG_PCI_SCAN_SHOW
>> + puts("PCI: pcie phy link never came up\n");
>> +#endif
>> debug("DEBUG_R0: 0x%08x, DEBUG_R1: 0x%08x\n",
>> readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R0),
>> readl(MX6_DBI_ADDR + PCIE_PHY_DEBUG_R1));
>> --
>> 1.9.1
>>
>
> Stefano,
>
> I probably should have sent this one to you directly being an imx driver.
>
I have seen the patch and the related discussion who should take care of
it ;-)
Do not worry - I set myself as delegate for this and I will merge it soon.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2015-05-27 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 22:17 [U-Boot] [PATCH] pci: imx: display message if no pcie link Tim Harvey
2015-05-22 20:50 ` [U-Boot] " Scott Wood
2015-05-22 21:17 ` Tim Harvey
2015-05-22 21:26 ` Tom Rini
2015-05-22 21:38 ` Scott Wood
2015-05-27 13:21 ` [U-Boot] [PATCH] " Tim Harvey
2015-05-27 13:30 ` Stefano Babic [this message]
2015-05-28 9:45 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565C6DC.8060609@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.