From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Sune Subject: Re: [PATCH 1/4] kni: add function to query the name of a kni object Date: Wed, 27 May 2015 16:15:49 +0200 Message-ID: <5565D195.9040701@bisdn.de> References: <1432734469-1668-1-git-send-email-bruce.richardson@intel.com> <5565CC22.8050003@bisdn.de> <20150527135533.GB10480@bricha3-MOBL3> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mx.bisdn.de (mx.bisdn.de [185.27.182.31]) by dpdk.org (Postfix) with ESMTP id 11ADD9E7 for ; Wed, 27 May 2015 16:15:52 +0200 (CEST) In-Reply-To: <20150527135533.GB10480@bricha3-MOBL3> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 27/05/15 15:55, Bruce Richardson wrote: > On Wed, May 27, 2015 at 03:52:34PM +0200, Marc Sune wrote: >> >> On 27/05/15 15:47, Bruce Richardson wrote: >>> When a KNI object is created, a name is assigned to it which is stored >>> internally. There is also an API function to look up a KNI object by >>> name, but there is no API to query the current name of an existing >>> KNI object. This patch adds just such an API. >>> >>> Signed-off-by: Bruce Richardson >>> --- >>> lib/librte_kni/rte_kni.c | 6 ++++++ >>> lib/librte_kni/rte_kni.h | 10 ++++++++++ >>> lib/librte_kni/rte_kni_version.map | 1 + >>> 3 files changed, 17 insertions(+) >>> >>> diff --git a/lib/librte_kni/rte_kni.c b/lib/librte_kni/rte_kni.c >>> index 4e70fa0..c5a0089 100644 >>> --- a/lib/librte_kni/rte_kni.c >>> +++ b/lib/librte_kni/rte_kni.c >>> @@ -674,6 +674,12 @@ rte_kni_get(const char *name) >>> return NULL; >>> } >>> +const char * >>> +rte_kni_get_name(const struct rte_kni *kni) >>> +{ >>> + return kni->name; >>> +} >> Since a pointer to the kni context (struct rte_kni) is exposed to the user >> (rte_kni_get() and rte_kni_alloc ()), and the field is directly in the >> struct, is this API call really necessary? I would only see this necessary >> if the API would only expose a handle, like a port_id for ethdev >> >> Marc > The structure definition is in rte_kni.c, not in the header file, so applications > can't read the name directly. In other words, the create API just exposes a handle. > [The structure in the header is the conf structure, not the full kni struct] Ops, you are right. I overlooked that. What about: extern void rte_kni_get_config(const struct rte_kni *kni, struct rte_kni_conf* conf); which fills in (copies) the fields of conf would allow to recover the original configuration, including the name? It is closer rte_eth_dev_info_get (unfortunately rte_kni_info_get is taken by the deprecated API), and would work if we add more params to rte_kni_conf. Thanks marc > /Bruce > >>> + >>> /* >>> * It is deprecated and just for backward compatibility. >>> */ >>> diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h >>> index 44240fe..0c74251 100644 >>> --- a/lib/librte_kni/rte_kni.h >>> +++ b/lib/librte_kni/rte_kni.h >>> @@ -248,6 +248,16 @@ extern uint8_t rte_kni_get_port_id(struct rte_kni *kni) \ >>> extern struct rte_kni *rte_kni_get(const char *name); >>> /** >>> + * Get the name given to a KNI device >>> + * >>> + * @param kni >>> + * The KNI instance to query >>> + * @return >>> + * The pointer to the KNI name >>> + */ >>> +extern const char *rte_kni_get_name(const struct rte_kni *kni); >>> + >>> +/** >>> * Get the KNI context of the specific port. >>> * >>> * Note: It is deprecated and just for backward compatibility. >>> diff --git a/lib/librte_kni/rte_kni_version.map b/lib/librte_kni/rte_kni_version.map >>> index b0bbf4d..e5e4e1b 100644 >>> --- a/lib/librte_kni/rte_kni_version.map >>> +++ b/lib/librte_kni/rte_kni_version.map >>> @@ -6,6 +6,7 @@ DPDK_2.0 { >>> rte_kni_create; >>> rte_kni_get; >>> rte_kni_get_port_id; >>> + rte_kni_get_name; >>> rte_kni_handle_request; >>> rte_kni_info_get; >>> rte_kni_init;