From: Florian Fainelli <f.fainelli@gmail.com>
To: Petri Gynther <pgynther@google.com>, linux-mips@linux-mips.org
Cc: ralf@linux-mips.org, cernekee@gmail.com
Subject: Re: [PATCH] MIPS: BMIPS: fix bmips_wr_vec()
Date: Wed, 27 May 2015 10:36:53 -0700 [thread overview]
Message-ID: <556600B5.70402@gmail.com> (raw)
In-Reply-To: <20150527062508.CD24722020B@puck.mtv.corp.google.com>
On 26/05/15 23:25, Petri Gynther wrote:
> bmips_wr_vec() copies exception vector code from start to dst.
>
> The call to dma_cache_wback() needs to flush (end-start) bytes,
> starting at dst, from write-back cache to memory.
>
> Signed-off-by: Petri Gynther <pgynther@google.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: df0ac8a406718 ("MIPS: BMIPS: Add SMP support code for
BMIPS43xx/BMIPS5000")
CC: stable@vger.kernel.org # 3.4+
> ---
> arch/mips/kernel/smp-bmips.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c
> index fd528d7..336708a 100644
> --- a/arch/mips/kernel/smp-bmips.c
> +++ b/arch/mips/kernel/smp-bmips.c
> @@ -444,7 +444,7 @@ struct plat_smp_ops bmips5000_smp_ops = {
> static void bmips_wr_vec(unsigned long dst, char *start, char *end)
> {
> memcpy((void *)dst, start, end - start);
> - dma_cache_wback((unsigned long)start, end - start);
> + dma_cache_wback(dst, end - start);
> local_flush_icache_range(dst, dst + (end - start));
> instruction_hazard();
> }
>
--
Florian
next prev parent reply other threads:[~2015-05-27 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 6:25 [PATCH] MIPS: BMIPS: fix bmips_wr_vec() Petri Gynther
2015-05-27 17:36 ` Florian Fainelli [this message]
2015-05-28 16:41 ` Ralf Baechle
2015-05-27 20:31 ` Kevin Cernekee
2015-05-28 16:40 ` Ralf Baechle
2015-05-28 16:47 ` Kevin Cernekee
2015-05-28 18:25 ` Petri Gynther
2015-05-28 18:59 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556600B5.70402@gmail.com \
--to=f.fainelli@gmail.com \
--cc=cernekee@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=pgynther@google.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.