From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxfs9-00035N-0j for qemu-devel@nongnu.org; Wed, 27 May 2015 14:16:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxfs4-00015M-Mv for qemu-devel@nongnu.org; Wed, 27 May 2015 14:16:08 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47434 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxfs4-00015A-C1 for qemu-devel@nongnu.org; Wed, 27 May 2015 14:16:04 -0400 Message-ID: <556609E1.2000004@suse.de> Date: Wed, 27 May 2015 20:16:01 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1432137106-8295-1-git-send-email-afaerber@suse.de> <20150521115346.GJ23116@redhat.com> In-Reply-To: <20150521115346.GJ23116@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/12] QOM devices patch queue 2015-05-20 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Peter Maydell Cc: Paolo Bonzini , QEMU Developers , Eduardo Habkost Am 21.05.2015 um 13:53 schrieb Daniel P. Berrange: > On Thu, May 21, 2015 at 12:18:30PM +0100, Peter Maydell wrote: >> On 20 May 2015 at 16:51, Andreas F=C3=A4rber wrote: >>> Hello Peter, >>> >>> This is my QOM (devices) patch queue. Please pull. >>> >>> Regards, >>> Andreas >>> >>> Cc: Peter Maydell >>> Cc: Eduardo Habkost >>> Cc: Paolo Bonzini >>> Cc: Daniel P. Berrange >>> >>> The following changes since commit faa261a7fb254866bdd5b6a25ad9467794= 5f21b4: >>> >>> Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-2015= 0519' into staging (2015-05-19 10:25:59 +0100) >>> >>> are available in the git repository at: >>> >>> git://github.com/afaerber/qemu-cpu.git tags/qom-devices-for-peter >>> >>> for you to fetch changes up to 28b86c32afbc53f9f06a5655da65f9d06fac1a= 3e: >>> >>> qom: Add object_property_add_const_link() (2015-05-20 17:40:47 +020= 0) >> >> Fails to build on my 32-bit ARM box, I'm afraid: >> >> tests/check-qom-proplist.c: In function 'test_dummy_badenum': >> tests/check-qom-proplist.c:225:6: error: value computed is not used >> [-Werror=3Dunused-value] >> >> My guess is this is a gcc-version-dependent thing rather >> than particularly 32-bit or ARM related. It's using >> gcc (Ubuntu/Linaro 4.7.2-2ubuntu1) 4.7.2 >=20 > Agreed, looks gcc version related not ARM/32-bit. >=20 > I'm thinking the following change applied to the patch > "qom: add a object_property_add_enum helper method" will probably > fix it >=20 > diff --git a/tests/check-qom-proplist.c b/tests/check-qom-proplist.c > index 8b764a1..7400b1f 100644 > --- a/tests/check-qom-proplist.c > +++ b/tests/check-qom-proplist.c > @@ -222,7 +222,7 @@ static void test_dummy_badenum(void) > { > Error *err =3D NULL; > Object *parent =3D object_get_objects_root(); > - DUMMY_OBJECT( > + Object *dobj =3D > object_new_with_props(TYPE_DUMMY, > parent, > "dummy0", > @@ -230,8 +230,9 @@ static void test_dummy_badenum(void) > "bv", "yes", > "sv", "Hiss hiss hiss", > "av", "yeti", > - NULL)); > + NULL); > =20 > + g_assert(dobj =3D=3D NULL); > g_assert(err !=3D NULL); > g_assert_cmpstr(error_get_pretty(err), =3D=3D, > "Invalid parameter 'yeti'"); Thanks, I've used this instead: - g_assert(err !=3D NULL); + g_assert_null(dobj); + g_assert_nonnull(err); More places could be cleaned up that way... Regards, Andreas P.S. Quite obviously with gcc 4.8.3 there were no issues on my side. --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Dilip Upmanyu, Graham Norton; = HRB 21284 (AG N=C3=BCrnberg)