All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted
Date: Thu, 28 May 2015 10:42:05 +0200	[thread overview]
Message-ID: <5566D4DD.8030507@redhat.com> (raw)
In-Reply-To: <87pp5lgko0.fsf@blackfin.pond.sub.org>



On 28/05/2015 10:39, Markus Armbruster wrote:
> > -    pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> > +    pc_basic_device_init(isa_bus, gsi, &rtc_state, force_fdctrl, &floppy,
> >                           (pc_machine->vmport != ON_OFF_AUTO_ON), 0xff0104);
> >  
> >      /* connect pm stuff to lpc */
> 
> If we can get from MachineState *machine to its MachineClass,

Sure you can, it's just MACHINE_GET_CLASS(machine).

Paolo

> we could
> use MachineClass member no_floppy, and not need force_fdctrl.  Probably
> a wash.

  reply	other threads:[~2015-05-28  8:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 21:06 [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither it nor floppy drives are wanted Laszlo Ersek
2015-05-28  8:19 ` Paolo Bonzini
2015-05-28  8:39 ` Markus Armbruster
2015-05-28  8:42   ` Paolo Bonzini [this message]
2015-05-28  9:38   ` Michael S. Tsirkin
2015-05-28  9:30 ` Kevin Wolf
2015-05-28 12:59 ` [Qemu-devel] [PATCH] i386: drop FDC in pc-q35-2.4+ if neither Gabriel L. Somlo
2015-05-28 13:52   ` Gerd Hoffmann
2015-05-28 14:42     ` Paolo Bonzini
2015-05-28 14:56       ` Gerd Hoffmann
2015-05-28 15:20         ` Paolo Bonzini
2015-05-28 15:49           ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5566D4DD.8030507@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.