From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxvJT-0000ZK-K2 for qemu-devel@nongnu.org; Thu, 28 May 2015 06:45:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YxvJO-00059z-Mk for qemu-devel@nongnu.org; Thu, 28 May 2015 06:45:23 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:57206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxvJO-00052P-G7 for qemu-devel@nongnu.org; Thu, 28 May 2015 06:45:18 -0400 Message-ID: <5566F1B4.6030300@msgid.tls.msk.ru> Date: Thu, 28 May 2015 13:45:08 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1432798845-10118-1-git-send-email-kraxel@redhat.com> <1432798845-10118-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1432798845-10118-2-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/2] kbd: add brazil kbd keys to x11 evdev map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , qemu-devel@nongnu.org Cc: gtk-vnc-list@gnome.org 28.05.2015 10:40, Gerd Hoffmann wrote: > This patch adds the two extra brazilian keys to the evdev keymap for > X11. This patch gets the two keys going with the vnc, gtk and sdl1 > UIs. > > The SDL2 library complains it doesn't know these keys, so the SDL2 > library must be fixed before we can update ui/sdl2-keymap.h Just a small nitpick: maybe you can actually add the necessary line to sdl2-keymap.h too, but comment it out, so the knowlege we gained in this episode remains in there? In either case, for both patches: Reviewed-by: Michael Tokarev Thank you for your work! /mjt