From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Kamil Debski <kamil@wypas.org>
Subject: Re: s5p-mfc: sparse warnings
Date: Thu, 28 May 2015 12:50:47 +0200 [thread overview]
Message-ID: <5566F307.6040600@samsung.com> (raw)
In-Reply-To: <555F356A.9030000@xs4all.nl>
Hello,
On 2015-05-22 15:55, Hans Verkuil wrote:
> Hi Marek, Kamil,
>
> Can someone look at these sparse warnings?
>
> s5p-mfc/s5p_mfc_opr_v5.c:266:23: warning: incorrect type in argument 2 (different address spaces)
> s5p-mfc/s5p_mfc_opr_v5.c:274:23: warning: incorrect type in argument 1 (different address spaces)
> s5p-mfc/s5p_mfc_opr_v6.c:1855:23: warning: incorrect type in argument 2 (different address spaces)
> s5p-mfc/s5p_mfc_opr_v6.c:1865:22: warning: incorrect type in argument 1 (different address spaces)
>
> It all depends on whether this is supposed to be __iomem memory or not.
>
> If it is supposed to be __iomem, then sparse will fail elsewhere (I saw at
> least one memset).
Well, this really looks messy. I will send a fix for it.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
prev parent reply other threads:[~2015-05-28 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 13:55 s5p-mfc: sparse warnings Hans Verkuil
2015-05-28 10:50 ` Marek Szyprowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5566F307.6040600@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=kamil@wypas.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.