From mboxrd@z Thu Jan 1 00:00:00 1970 From: Razvan Cojocaru Subject: Re: [PATCH V7] xen/vm_event: Clean up control-register-write vm_events and add XCR0 event Date: Thu, 28 May 2015 13:56:21 +0300 Message-ID: <5566F455.40301@bitdefender.com> References: <1432791185-24668-1-git-send-email-rcojocaru@bitdefender.com> <5566F079020000780007E699@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5566F079020000780007E699@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: tim@xen.org, kevin.tian@intel.com, wei.liu2@citrix.com, eddie.dong@intel.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jun.nakajima@intel.com, keir@xen.org, ian.campbell@citrix.com List-Id: xen-devel@lists.xenproject.org On 05/28/2015 11:39 AM, Jan Beulich wrote: >>>> On 28.05.15 at 07:33, wrote: >> Changes since V6: >> - Removed "Reviewed-by: Tim Deegan ", as the patch >> went beyond cosmetic-only changes. >> - Parenthesized hvm_event_cr in event.c, to prevent expansion of >> the macro with the same name if event.h gets #included. > > I'm sorry, but I specifically said that you need to include the header > declaring the function (and macro) in the file defining it, but ... > >> --- a/xen/arch/x86/hvm/event.c >> +++ b/xen/arch/x86/hvm/event.c >> @@ -21,6 +21,7 @@ >> >> #include >> #include >> +#include >> #include >> >> static void hvm_event_fill_regs(vm_event_request_t *req) > > ... you didn't (and you also didn't in a prereq patch, which would have > been the alternative). I see, sorry for the misunderstanding - I read your comment to mean that in case the header gets included at a later time there might be problems, which now won't happen. I will re-submit with the proper header included. Thanks, Razvan