From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753973AbbE1LjI (ORCPT ); Thu, 28 May 2015 07:39:08 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:9781 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753425AbbE1LjE (ORCPT ); Thu, 28 May 2015 07:39:04 -0400 Message-ID: <5566FE32.6000300@huawei.com> Date: Thu, 28 May 2015 19:38:26 +0800 From: "Ouyang Zhaowei (Charles)" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: David Vrabel , Boris Ostrovsky , Konrad Rzeszutek Wilk CC: , Dingweiping , Yanqiangjun , Subject: Re: [RESEND PATCH] xen: vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu References: <55497298.4070307@huawei.com> <5566F6FE.30607@citrix.com> In-Reply-To: <5566F6FE.30607@citrix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.30.65] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015.5.28 19:07, David Vrabel wrote: > On 06/05/15 02:47, Ouyang Zhaowei (Charles) wrote: >> vcpu_info would be reset to wrong place on canceled suspend on PVOPS VM which has multi-cpu >> >> The hypervisor continues assuming that vcpu_info is stored in per-cpu data which was set up by xen_vcpu_setup(), >> while on canceled suspend, the call to xen_hvm_init_shared_info() will make the guest think that vcpu_info >> is in the shared page. This will cause non-boot cpus keep checking a wrong vcpu_info address and can not handle >> irqs any more after suspend canceled, for example after we do "xl save -c/restore", PVOPS VM can not be resumed >> as the cpus can not finish their irqs. >> >> >> Signed-off-by: Charles Ouyang >> Reviewed-by: Boris Ostrovsky >> Reviewed-by: David Vrabel > > 1. I don't think I offered a reviewed-by tag for this patch > 2. You did not Cc the xen-devel mailing list on this patch. > 3. The patch is white-space damaged. > 4. The commit message has lines longer than ~72 chars. Sorry about that, this is my first time to send patch, and I didn't notice that it was white-space damaged. I'll modify the patch and commit message as you applied and Cc Xen-devel mailing list. Thanks Ouyang Zhaowei > > But I've applied this to for-linus-4.1b anyway, thanks. > > David > > > . >