From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YxwnC-0002gJ-8Q for mharc-qemu-trivial@gnu.org; Thu, 28 May 2015 08:20:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwn3-0002PK-JG for qemu-trivial@nongnu.org; Thu, 28 May 2015 08:20:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwmy-0006rL-H5 for qemu-trivial@nongnu.org; Thu, 28 May 2015 08:20:01 -0400 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:53839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwmy-0006nx-Bx; Thu, 28 May 2015 08:19:56 -0400 Received: from 4e56a460.skybroadband.com ([78.86.164.96] helo=[192.168.1.87]) by s16892447.onlinehome-server.info with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1Yxwmj-0003Jt-Lb; Thu, 28 May 2015 13:19:42 +0100 Message-ID: <556707D2.50800@ilande.co.uk> Date: Thu, 28 May 2015 13:19:30 +0100 From: Mark Cave-Ayland User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Michael Tokarev , Shannon Zhao , qemu-devel@nongnu.org References: <1432811625-13392-1-git-send-email-zhaoshenglong@huawei.com> <1432811625-13392-5-git-send-email-zhaoshenglong@huawei.com> <556701E8.1040801@msgid.tls.msk.ru> <556703B2.8050606@msgid.tls.msk.ru> In-Reply-To: <556703B2.8050606@msgid.tls.msk.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 78.86.164.96 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk X-SA-Exim-Version: 4.2.1 (built Sun, 08 Jan 2012 02:45:44 +0000) X-SA-Exim-Scanned: Yes (on s16892447.onlinehome-server.info) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 82.165.15.123 Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, shannon.zhao@linaro.org Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 12:20:08 -0000 On 28/05/15 13:01, Michael Tokarev wrote: > 28.05.2015 14:54, Michael Tokarev wrote: >> Applied to -trivial, thanks! > > ..or not applied yet... :) > > This is again the same situation with the error message as with > 1/4 hw/display/cg3.c, and the same question - is the error fatal? > > And note that you're the number-one person who made changes to > this file... ;) > > /mjt The FCode ROMs supplied for CG3/TCX are used to both initialise various DT entries for the graphic adapters and also provide a minimal driver to allow OpenBIOS (or Sun PROM) to initialise and use the adapter at boot. I'd say at the moment the error should be fatal, since the correct way to have a headless system would be not to have the virtual graphics adapter plugged into the system in the first place. Otherwise I can see that the skeleton DT nodes generated by the PROM would be missing several properties generated by the FCode (such as the framebuffer address), which would be utterly confusing for any client trying to use the graphics adapter. ATB, Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxwnE-0002ky-Uv for qemu-devel@nongnu.org; Thu, 28 May 2015 08:20:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwn9-0007CT-UE for qemu-devel@nongnu.org; Thu, 28 May 2015 08:20:12 -0400 Message-ID: <556707D2.50800@ilande.co.uk> Date: Thu, 28 May 2015 13:19:30 +0100 From: Mark Cave-Ayland MIME-Version: 1.0 References: <1432811625-13392-1-git-send-email-zhaoshenglong@huawei.com> <1432811625-13392-5-git-send-email-zhaoshenglong@huawei.com> <556701E8.1040801@msgid.tls.msk.ru> <556703B2.8050606@msgid.tls.msk.ru> In-Reply-To: <556703B2.8050606@msgid.tls.msk.ru> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev , Shannon Zhao , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, shannon.zhao@linaro.org On 28/05/15 13:01, Michael Tokarev wrote: > 28.05.2015 14:54, Michael Tokarev wrote: >> Applied to -trivial, thanks! > > ..or not applied yet... :) > > This is again the same situation with the error message as with > 1/4 hw/display/cg3.c, and the same question - is the error fatal? > > And note that you're the number-one person who made changes to > this file... ;) > > /mjt The FCode ROMs supplied for CG3/TCX are used to both initialise various DT entries for the graphic adapters and also provide a minimal driver to allow OpenBIOS (or Sun PROM) to initialise and use the adapter at boot. I'd say at the moment the error should be fatal, since the correct way to have a headless system would be not to have the virtual graphics adapter plugged into the system in the first place. Otherwise I can see that the skeleton DT nodes generated by the PROM would be missing several properties generated by the FCode (such as the framebuffer address), which would be utterly confusing for any client trying to use the graphics adapter. ATB, Mark.