From: Stanislav Brabec <sbrabec@suse.cz>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org
Subject: Re: [PATCH] Fix /dev to /sys node name translation
Date: Thu, 28 May 2015 15:02:45 +0200 [thread overview]
Message-ID: <556711F5.9000109@suse.cz> (raw)
In-Reply-To: <20150528104005.GB7285@ws.net.home>
Karel Zak wrote:
> because the original names have been too tricky :-)
When I created the first one, I did not think that reverse will be needed.
> I have also changed some thing in sysfs.c, it would be nice if we can
> keep the crazy sysfs devnames (with '!') really only in sysfs specific
> code and externally provide regular device names.
>
> Please, test it -- especially lsblk.
fdisk -l works, lsblk -f is broken again. lsblk worked before, but it
used '!'.
Before starting to play with '!' (687cc5d):
cciss-test:~/util-linux # ./lsblk -f
NAME FSTYPE LABEL MOUNTPOINT
cciss!c0d0
├─cciss!c0d0p1
├─cciss!c0d0p2
└─cciss!c0d0p3
cciss-test:~/util-linux # ./fdisk -l
cciss-test:~/util-linux #
After 759b120: lib/sysfs: Fix /dev to /sys node name translation:
cciss-test:~/util-linux # ./lsblk -f
NAME FSTYPE LABEL UUID MOUNTPOINT
cciss!c0d0
├─cciss!c0d0p1 ext3 Boot 126055ae-08fd-4da3-a8ad-7e150d268edb /boot
├─cciss!c0d0p2 swap e4e0d080-2b69-4ece-aeb5-e2190ad2934b [SWAP]
└─cciss!c0d0p3 btrfs 6b184ec0-512c-4620-8dc1-856a0b85969f /
cciss-test:~/util-linux # ./fdisk -l
Disk /dev/cciss/c0d0: 136.7 GiB, 146778685440 bytes, 286677120 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x0002fc74
Device Boot Start End Sectors Size Id Type
/dev/cciss/c0d0p1 * 2048 321535 319488 156M 83 Linux
/dev/cciss/c0d0p2 321536 4530175 4208640 2G 82 Linux swap / Solaris
/dev/cciss/c0d0p3 4530176 286676991 282146816 134.6G 83 Linux
cciss-test:~/util-linux #
HEAD d5dbd57:
cciss-test:~/util-linux # ./lsblk -f
cciss-test:~/util-linux # ./fdisk -l
Disk /dev/cciss/c0d0: 136.7 GiB, 146778685440 bytes, 286677120 sectors
Units: sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disklabel type: dos
Disk identifier: 0x0002fc74
Device Boot Start End Sectors Size Id Type
/dev/cciss/c0d0p1 * 2048 321535 319488 156M 83 Linux
/dev/cciss/c0d0p2 321536 4530175 4208640 2G 82 Linux swap / Solaris
/dev/cciss/c0d0p3 4530176 286676991 282146816 134.6G 83 Linux
cciss-test:~/util-linux #
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz
Lihovarská 1060/12 tel: +49 911 7405384547
190 00 Praha 9 fax: +420 284 084 001
Czech Republic http://www.suse.cz/
PGP: 830B 40D5 9E05 35D8 5E27 6FA3 717C 209F A04F CD76
prev parent reply other threads:[~2015-05-28 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 13:12 [PATCH] Fix /dev to /sys node name translation Stanislav Brabec
2015-05-28 10:40 ` Karel Zak
2015-05-28 13:02 ` Stanislav Brabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556711F5.9000109@suse.cz \
--to=sbrabec@suse.cz \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.