From: Ben Greear <greearb@candelatech.com>
To: Adrian Chadd <adrian@freebsd.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: compiling decode_ath10k.cc with clang/llvm
Date: Thu, 28 May 2015 07:08:41 -0700 [thread overview]
Message-ID: <55672169.8080209@candelatech.com> (raw)
In-Reply-To: <CAJ-VmonBGgLdLy8KQwYt81+2tfMYzw+OY+VMSCmGy315wUP+EQ@mail.gmail.com>
That is from my private tree, so list cannot help you...
Looks like real bugs...I'll make attempt at fixing it.
Thanks,
Ben
On 05/27/2015 11:43 PM, Adrian Chadd wrote:
> Hi,
>
> I'm doing firmware bringup on freebsd, and I've hit a snag with
> decode_ath10k.cc:
>
> Suspended
> adrian@lucy-11i386:~/git/dev.qualcomm.com/greaarb/ath10k-firmware % ./BUILDME.sh
> decode_ath10k.cc:1266:28: error: use of logical '&&' with constant
> operand [-Werror,-Wconstant-logical-operand]
> (ps_reg >> 8) && 0xf, (ps_reg >> 16) & 0x3, !!(ps_reg >> 18));
> ^ ~~~
> decode_ath10k.cc:1266:28: note: use '&' for a bitwise operation
> (ps_reg >> 8) && 0xf, (ps_reg >> 16) & 0x3, !!(ps_reg >> 18));
> ^~
> &
> decode_ath10k.cc:1266:28: note: remove constant to silence this warning
> (ps_reg >> 8) && 0xf, (ps_reg >> 16) & 0x3, !!(ps_reg >> 18));
> ~^~~~~~
> decode_ath10k.cc:1407:37: error: comparison of unsigned expression >=
> 0 is always true [-Werror,-Wtautological-compare]
> if ((sp_idx >= 0) && (sp_idx < len)) {
> ~~~~~~ ^ ~
> decode_ath10k.cc:2019:23: error: format specifies type 'unsigned
> short' but the argument has type 'unsigned char' [-Werror,-Wformat]
> printf("%02hx", header.uuid[i]);
> ~~~~~ ^~~~~~~~~~~~~~
> %02hhx
>
> .. would someone who can use the firmware try fixing the source and
> see if it still does the right thing?
>
>
> -a
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-05-28 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 6:43 compiling decode_ath10k.cc with clang/llvm Adrian Chadd
2015-05-28 14:08 ` Ben Greear [this message]
2015-05-28 16:49 ` Adrian Chadd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55672169.8080209@candelatech.com \
--to=greearb@candelatech.com \
--cc=adrian@freebsd.org \
--cc=ath10k@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.