Re: [Qemu-devel] [PATCH 3/9] vl: Fail right after first bad -object

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

On 05/28/2015 06:21 AM, Markus Armbruster wrote:
> Failure to create a -object is a fatal error.  However, we delay the

s/a -object/an -object/ ? (depends on whether you pronounce '-object' as
"object" or "dash-object")

> actual exit until all -object are processed.  On the one hand, this
> permits detection of genuine additional errors.  On the other hand, it
> can muddy the waters with uninteresting additional errors, e.g. when a
> later -object tries to reference a prior one that failed.
> 
> We generally stop right on the first bad option, so do that for
> -object as well.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  vl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]