From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <dvrabel@cantab.net>
Subject: Re: [PATCHv10 4/4] gnttab: use per-VCPU maptrack free
 lists
Date: Thu, 28 May 2015 17:10:32 +0100
Message-ID: <55673DF8.5060505@cantab.net>
References: <1432663228-27680-1-git-send-email-david.vrabel@citrix.com>	<1432663228-27680-5-git-send-email-david.vrabel@citrix.com>
	<556752CA020000780007EB08@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <d.vrabel.98@gmail.com>) id 1Yy0OB-0008AT-PU
	for xen-devel@lists.xenproject.org; Thu, 28 May 2015 16:10:35 +0000
Received: by wgv5 with SMTP id 5so40746092wgv.1
	for <xen-devel@lists.xenproject.org>;
	Thu, 28 May 2015 09:10:34 -0700 (PDT)
In-Reply-To: <556752CA020000780007EB08@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, David Vrabel <david.vrabel@citrix.com>
Cc: xen-devel@lists.xenproject.org, Malcolm Crossley <malcolm.crossley@citrix.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 28/05/15 16:39, Jan Beulich wrote:
>>>> On 26.05.15 at 20:00, <david.vrabel@citrix.com> wrote:
>> --- a/xen/common/grant_table.c
>> +++ b/xen/common/grant_table.c
>> @@ -57,7 +57,7 @@ integer_param("gnttab_max_frames", max_grant_frames);
>>   * New options allow to set max_maptrack_frames and
>>   * map_grant_table_frames independently.
>>   */
>> -#define DEFAULT_MAX_MAPTRACK_FRAMES 256
>> +#define DEFAULT_MAX_MAPTRACK_FRAMES 1024
> 
> Apart from everything else this again results in ...
> 
>> @@ -1457,6 +1491,17 @@ gnttab_setup_table(
>>      gt = d->grant_table;
>>      write_lock(&gt->lock);
>>  
>> +    /* Tracking of mapped foreign frames table */
>> +    gt->maptrack = xzalloc_array(struct grant_mapping *, max_maptrack_frames);
> 
> ... this becoming an order-1 runtime allocation on other than 32-bit
> ARM.

I thought we agreed that this was temporary until vzalloc() was added?

David