From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754347AbbE1SKL (ORCPT ); Thu, 28 May 2015 14:10:11 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:34964 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753518AbbE1SKC (ORCPT ); Thu, 28 May 2015 14:10:02 -0400 Message-ID: <556759F9.9020908@plumgrid.com> Date: Thu, 28 May 2015 11:10:01 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: He Kuang , Masami Hiramatsu , wangnan0@huawei.com, paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, brendan.d.gregg@gmail.com, daniel@iogearbox.net CC: lizefan@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 09/15] perf probe: Support $params without debuginfo References: <1432456091-73384-1-git-send-email-hekuang@huawei.com> <1432456091-73384-10-git-send-email-hekuang@huawei.com> <556190AA.10406@hitachi.com> <5562DE44.4010601@huawei.com> <5564B279.2090809@plumgrid.com> <55652B7B.2040409@huawei.com> <5565E331.7010606@plumgrid.com> <55671195.5040501@huawei.com> In-Reply-To: <55671195.5040501@huawei.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/28/15 6:01 AM, He Kuang wrote: >> I don't think you can break it down in two steps like this. >> >There is no such thing as 'calling regs'. x86_32 with ax,dx,cx >> >are not 'calling regs'. 64-bit values will be passed in a pair. >> >Only 'pt_regs + arch + func_proto + asmlinkage' makes sense >> >from the user point of view. >> >Adding 'asmlinkage' attr is also trivial. >> >'func(long, char) asmlinkage' is easy to parse and the user > I think at this early stage, we could make our bpf variable > prologue work with debuginfo while keeping bpf 'SEC' syntax > consistent with original perf probe. After all, we can use > pt_regs directly or relay to perf-probe cache by Masami to deal > with non-debug cases. so you're saying you don't want to support non-debug case for now? Sure, as long as section name parser will be able to support 'func(long, char) asmlinkage' syntax in the future without breaking compatibility. I'm mostly interested in cases when debug info is not available at all. So perf-probe cache is of no use to me.