From: Florian Fainelli <f.fainelli@gmail.com>
To: Petri Gynther <pgynther@google.com>
Cc: netdev <netdev@vger.kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill
Date: Thu, 28 May 2015 21:02:30 -0700 [thread overview]
Message-ID: <5567E4D6.3030409@gmail.com> (raw)
In-Reply-To: <CAGXr9JEEGSVKVgqzNTWePytjiFCqK32k4YWZGtORskW5H3Atbw@mail.gmail.com>
Le 05/28/15 20:58, Petri Gynther a écrit :
[snip]
>> /* We do not have a backing SKB, so we do not a corresponding
>
> Is this comment still valid? I removed it from bcmgenet.
Not really, thanks, I will fix that in v2.
[snip]
>> +
>> + if (priv->rx_read_ptr == priv->num_rx_bds)
>
> if (unlikely(priv->rx_read_ptr == priv->num_rx_bds))
Will fix that as well, thank you!
--
Florian
next prev parent reply other threads:[~2015-05-29 4:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 22:24 [PATCH net-next 0/3] net: systemport: misc improvements Florian Fainelli
2015-05-28 22:24 ` [PATCH net-next 1/3] net: systemport: Pre-calculate and utilize cb->bd_addr Florian Fainelli
2015-05-29 3:43 ` Petri Gynther
2015-05-28 22:24 ` [PATCH net-next 2/3] net: systemport: rewrite bcm_sysport_rx_refill Florian Fainelli
2015-05-29 3:58 ` Petri Gynther
2015-05-29 4:02 ` Florian Fainelli [this message]
2015-05-28 22:24 ` [PATCH net-next 3/3] net: systemport: Add a check for oversized packets Florian Fainelli
2015-05-29 4:00 ` Petri Gynther
2015-05-31 6:51 ` [PATCH net-next 0/3] net: systemport: misc improvements David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5567E4D6.3030409@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pgynther@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.