From: Junichi Nomura <j-nomura@ce.jp.nec.com>
To: device-mapper development <dm-devel@redhat.com>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: dm: fix false alarm in free_rq_clone() for non blk-mq target
Date: Fri, 29 May 2015 04:17:49 +0000 [thread overview]
Message-ID: <5567E86D.7080204@ce.jp.nec.com> (raw)
In-Reply-To: <20150529031842.GA26268@redhat.com>
On 05/29/15 12:18, Mike Snitzer wrote:
>> So I don't think it's necessary to extend dm_end_request() with 'mapped'
>> parameter.
>
> I'm starting to question the need for 'must_be_mapped' param to
> free_rq_clone(). It was motivated by strange reports from Bart's
> testing but in reality I don't think it ever actually helped.
>
> It was to act as a canary in the coal mine for the future but I'm now
> more inclined to just remove the parameter entirely. Or do you think
> 'must_be_mapped' is still useful?
No. I think removing the parameter is good.
--
Jun'ichi Nomura, NEC Corporation
prev parent reply other threads:[~2015-05-29 4:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 7:59 [PATCH] dm: fix false alarm in free_rq_clone() for non blk-mq target Junichi Nomura
2015-05-28 19:14 ` Mike Snitzer
2015-05-29 0:29 ` Junichi Nomura
2015-05-29 3:18 ` Mike Snitzer
2015-05-29 4:17 ` Junichi Nomura [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5567E86D.7080204@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=dm-devel@redhat.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.