All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	 Shannon Zhao <zhaoshenglong@huawei.com>,
	qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, shannon.zhao@linaro.org
Subject: Re: [Qemu-trivial] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind
Date: Fri, 29 May 2015 09:18:35 +0300	[thread overview]
Message-ID: <556804BB.4090702@msgid.tls.msk.ru> (raw)
In-Reply-To: <556707D2.50800@ilande.co.uk>

28.05.2015 15:19, Mark Cave-Ayland wrote:
[]
> The FCode ROMs supplied for CG3/TCX are used to both initialise various
> DT entries for the graphic adapters and also provide a minimal driver to
> allow OpenBIOS (or Sun PROM) to initialise and use the adapter at boot.
> 
> I'd say at the moment the error should be fatal, [...]

So it looks like some exit(1) or similar is missing after error_report()
in these cases, which should be added :)  Thanks!

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
	Shannon Zhao <zhaoshenglong@huawei.com>,
	qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, shannon.zhao@linaro.org
Subject: Re: [Qemu-devel] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind
Date: Fri, 29 May 2015 09:18:35 +0300	[thread overview]
Message-ID: <556804BB.4090702@msgid.tls.msk.ru> (raw)
In-Reply-To: <556707D2.50800@ilande.co.uk>

28.05.2015 15:19, Mark Cave-Ayland wrote:
[]
> The FCode ROMs supplied for CG3/TCX are used to both initialise various
> DT entries for the graphic adapters and also provide a minimal driver to
> allow OpenBIOS (or Sun PROM) to initialise and use the adapter at boot.
> 
> I'd say at the moment the error should be fatal, [...]

So it looks like some exit(1) or similar is missing after error_report()
in these cases, which should be added :)  Thanks!

/mjt

  reply	other threads:[~2015-05-29  6:18 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28 11:13 [Qemu-trivial] [PATCH 0/4] Fix memory leak due to calling qemu_find_file and not freeing return buf Shannon Zhao
2015-05-28 11:13 ` [Qemu-devel] " Shannon Zhao
2015-05-28 11:13 ` [Qemu-trivial] [PATCH 1/4] hw/display/cg3.c: Fix memory leak Shannon Zhao
2015-05-28 11:13   ` [Qemu-devel] " Shannon Zhao
2015-05-28 11:55   ` [Qemu-trivial] " Michael Tokarev
2015-05-28 11:55     ` [Qemu-devel] " Michael Tokarev
2015-05-28 12:08     ` Shannon Zhao
2015-05-28 12:08       ` [Qemu-devel] " Shannon Zhao
2015-05-28 11:13 ` [Qemu-trivial] [PATCH 2/4] hw/alpha/dp264.c: Fix memory leak spotted by valgrind Shannon Zhao
2015-05-28 11:13   ` [Qemu-devel] " Shannon Zhao
2015-05-28 11:50   ` [Qemu-trivial] " Michael Tokarev
2015-05-28 11:50     ` [Qemu-devel] " Michael Tokarev
2015-05-28 11:58     ` [Qemu-trivial] " Shannon Zhao
2015-05-28 11:58       ` [Qemu-devel] " Shannon Zhao
2015-05-28 11:13 ` [Qemu-trivial] [PATCH 3/4] hw/ppc/e500.c: Fix memory leak Shannon Zhao
2015-05-28 11:13   ` [Qemu-devel] " Shannon Zhao
2015-05-28 11:57   ` [Qemu-trivial] " Michael Tokarev
2015-05-28 11:57     ` [Qemu-devel] " Michael Tokarev
2015-05-28 11:13 ` [Qemu-trivial] [PATCH 4/4] hw/display/tcx.c: Fix memory leak spotted by valgrind Shannon Zhao
2015-05-28 11:13   ` [Qemu-devel] " Shannon Zhao
2015-05-28 11:54   ` [Qemu-trivial] " Michael Tokarev
2015-05-28 11:54     ` [Qemu-devel] " Michael Tokarev
2015-05-28 12:01     ` [Qemu-trivial] " Michael Tokarev
2015-05-28 12:01       ` [Qemu-devel] " Michael Tokarev
2015-05-28 12:19       ` [Qemu-trivial] " Mark Cave-Ayland
2015-05-28 12:19         ` Mark Cave-Ayland
2015-05-29  6:18         ` Michael Tokarev [this message]
2015-05-29  6:18           ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556804BB.4090702@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    --cc=zhaoshenglong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.