From: Bhuvanchandra DV <bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
To: "Jakub Kiciński" <moorray3-5tc4TXWwyLM@public.gmane.org>
Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stefan-XLVq0VzYD2Y@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
jslaby-AlSwsSmVLrQ@public.gmane.org,
linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bhuvanchandra.dv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Fri, 29 May 2015 15:40:31 +0530 [thread overview]
Message-ID: <55683B17.1010706@toradex.com> (raw)
In-Reply-To: <20150529120421.754fd6ab@north>
Hello Jakub,
On 05/29/2015 03:34 PM, Jakub Kiciński wrote:
> On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote:
>> The LPUART does not provide manual control of RTS/CTS signals,
>> those can only be controlled by the hardware directly. Therefore
>> manual control of those signals through mctrl can not be provided.
>> The current implementation enables/disables the automatic control,
>> which is not what mctrl should do, hence remove the incorrect
>> implementation.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
>
> Now that the functions do nothing there is probably no point in keeping
> separate lpuart/lpuart32 variants.
Agreed, will update it accordingly.
Thanks! for pointing this.
>
Best regards,
Bhuvan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: bhuvanchandra.dv@toradex.com (Bhuvanchandra DV)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Fri, 29 May 2015 15:40:31 +0530 [thread overview]
Message-ID: <55683B17.1010706@toradex.com> (raw)
In-Reply-To: <20150529120421.754fd6ab@north>
Hello Jakub,
On 05/29/2015 03:34 PM, Jakub Kici?ski wrote:
> On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote:
>> The LPUART does not provide manual control of RTS/CTS signals,
>> those can only be controlled by the hardware directly. Therefore
>> manual control of those signals through mctrl can not be provided.
>> The current implementation enables/disables the automatic control,
>> which is not what mctrl should do, hence remove the incorrect
>> implementation.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>
> Now that the functions do nothing there is probably no point in keeping
> separate lpuart/lpuart32 variants.
Agreed, will update it accordingly.
Thanks! for pointing this.
>
Best regards,
Bhuvan
WARNING: multiple messages have this Message-ID (diff)
From: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
To: "Jakub Kiciński" <moorray3@wp.pl>
Cc: <gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<stefan@agner.ch>, <shawn.guo@linaro.org>,
<kernel@pengutronix.de>, <jslaby@suse.cz>,
<linux-serial@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <bhuvanchandra.dv@gmail.com>
Subject: Re: [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl
Date: Fri, 29 May 2015 15:40:31 +0530 [thread overview]
Message-ID: <55683B17.1010706@toradex.com> (raw)
In-Reply-To: <20150529120421.754fd6ab@north>
Hello Jakub,
On 05/29/2015 03:34 PM, Jakub Kiciński wrote:
> On Fri, 29 May 2015 13:35:53 +0530, Bhuvanchandra DV wrote:
>> The LPUART does not provide manual control of RTS/CTS signals,
>> those can only be controlled by the hardware directly. Therefore
>> manual control of those signals through mctrl can not be provided.
>> The current implementation enables/disables the automatic control,
>> which is not what mctrl should do, hence remove the incorrect
>> implementation.
>>
>> Signed-off-by: Bhuvanchandra DV <bhuvanchandra.dv@toradex.com>
>
> Now that the functions do nothing there is probably no point in keeping
> separate lpuart/lpuart32 variants.
Agreed, will update it accordingly.
Thanks! for pointing this.
>
Best regards,
Bhuvan
next prev parent reply other threads:[~2015-05-29 10:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 8:05 [PATCH 0/3] Add RS-485 support and fix RTS/CTS implementation Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 8:05 ` [PATCH 1/3] ARM: dts: colibri-vf: Add pinmux for UART_0 aka UART_A RTS/CTS pins Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 8:05 ` [PATCH 2/3] tty: serial: fsl_lpuart: remove RTS/CTS control from set/get_mctrl Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 10:04 ` Jakub Kiciński
2015-05-29 10:04 ` Jakub Kiciński
2015-05-29 10:04 ` Jakub Kiciński
2015-05-29 10:10 ` Bhuvanchandra DV [this message]
2015-05-29 10:10 ` Bhuvanchandra DV
2015-05-29 10:10 ` Bhuvanchandra DV
2015-05-29 8:05 ` [PATCH 3/3] tty: serial: fsl_lpuart: Add support for RS-485 Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 8:05 ` Bhuvanchandra DV
2015-05-29 10:18 ` Jakub Kiciński
2015-05-29 10:18 ` Jakub Kiciński
2015-05-29 10:18 ` Jakub Kiciński
2015-05-29 10:42 ` Bhuvanchandra DV
2015-05-29 10:42 ` Bhuvanchandra DV
2015-05-29 10:42 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55683B17.1010706@toradex.com \
--to=bhuvanchandra.dv-2kbjvhiyjgbbdgjk7y7tuq@public.gmane.org \
--cc=bhuvanchandra.dv-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=jslaby-AlSwsSmVLrQ@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=moorray3-5tc4TXWwyLM@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=stefan-XLVq0VzYD2Y@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.