From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH V4 5/8] tools/libxl: Set 'reg' of cpu node equal to MPIDR affinity for domU Date: Fri, 29 May 2015 17:08:08 +0100 Message-ID: <55688EE8.8030200@citrix.com> References: <1432808109-31466-1-git-send-email-cbz@baozis.org> <1432808109-31466-6-git-send-email-cbz@baozis.org> <55688958.2090507@citrix.com> <1432914920.15036.65.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YyMrB-0001pQ-J9 for xen-devel@lists.xenproject.org; Fri, 29 May 2015 16:10:01 +0000 In-Reply-To: <1432914920.15036.65.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, Chen Baozi , Chen Baozi List-Id: xen-devel@lists.xenproject.org On 29/05/15 16:55, Ian Campbell wrote: > On Fri, 2015-05-29 at 16:44 +0100, Julien Grall wrote: > >>> + name = GCSPRINTF("cpu@%lx", mpidr_aff); >> >> It's not necessary to change the cpu@. > > AIUI it is conventional in DT for this to match the first reg entry. Well, it's conventional when the reg field is containing an address. It's not the case of the cpu node as "reg" doesn't contain an address. There is a mix of both in the different DTS. Although, increment an ID make easier to read the dumped DTS for debugging. Regards, -- Julien Grall