Re: [Qemu-devel] [PATCH v2 3/3] icount: print a warning if there is no more deadline in sleep=no mode

[Paolo Bonzini <pbonzini@redhat.com>]

On 29/05/2015 17:14, Victor CLEMENT wrote:
> While qemu is running in sleep=no mode, a warning will be printed
> when no timer deadline is set.
> As this mode is intended for getting deterministic virtual time, if no
> timer is set on the virtual clock this determinism is broken.
> 
> Signed-off-by: Victor CLEMENT <victor.clement@openwide.fr>
> ---
>  cpus.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/cpus.c b/cpus.c
> index 4e90e63..aec17b6 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -419,6 +419,12 @@ void qemu_clock_warp(QEMUClockType type)
>      clock = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL_RT);
>      deadline = qemu_clock_deadline_ns_all(QEMU_CLOCK_VIRTUAL);
>      if (deadline < 0) {
> +        static bool notified;
> +        if (!icount_sleep && !notified) {
> +            fprintf(stderr, "cpus: WARNING: icount sleep disabled and no more \
> +active timer\n");

I'm changing this to error_report, and queuing the series for 2.4 with
no other changes.  Expect it to be in a pull request next week!

Paolo

> +            notified = true;
> +        }
>          return;
>      }
>  
>