From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH V4 7/8] xen/arm64: increase MAX_VIRT_CPUS to
 128 on arm64
Date: Fri, 29 May 2015 17:45:08 +0100
Message-ID: <55689794.9080000@citrix.com>
References: <1432808109-31466-1-git-send-email-cbz@baozis.org>
	<1432808109-31466-8-git-send-email-cbz@baozis.org>
	<55688B17.8040104@citrix.com> <556891D3.8040400@citrix.com>
	<556896CE.8050308@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=5840ebdcf=julien.grall@citrix.com>)
	id 1YyNPq-0006Rf-Hh
	for xen-devel@lists.xenproject.org; Fri, 29 May 2015 16:45:50 +0000
In-Reply-To: <556896CE.8050308@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Chen Baozi <cbz@baozis.org>, xen-devel@lists.xenproject.org
Cc: Chen Baozi <baozich@gmail.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 29/05/15 17:41, Andrew Cooper wrote:
> On 29/05/15 17:20, Julien Grall wrote:
>> On 29/05/15 16:51, Julien Grall wrote:
>>>> diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
>>>> index 3b23e05..817c216 100644
>>>> --- a/xen/include/asm-arm/config.h
>>>> +++ b/xen/include/asm-arm/config.h
>>>> @@ -47,7 +47,11 @@
>>>>  #define NR_CPUS 128
>>>>  #endif
>>>>  
>>>> +#ifdef CONFIG_ARM_64
>>>> +#define MAX_VIRT_CPUS 128
>>>> +#else
>>>>  #define MAX_VIRT_CPUS 8
>>>> +#endif
>> Looking to the last patch, the usage of MAX_VIRT_CPUS is now minimal.
>> Can't finish to replace MAX_VIRT_CPUS to another corresponding value and
>> drop the define?
> 
> You cant drop MAX_VIRT_CPUS (I tried this when introducing
> max_domain_vcpus()). It is used for some conditional compilation in
> common code.

AFAICT only in the event channel code to avoid allocating memory when
less than 64 vCPU is used.

Anyway, if we can drop it. I would add a check in domain_max_vcpus for
safety.

Regards,

-- 
Julien Grall