All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: virtio-blk <qemu-block@nongnu.org>,
	mst@redhat.com, Cornelia Huck <cornelia.huck@de.ibm.com>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Amit Shah <amit.shah@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2] virtio: make features 64bit wide
Date: Fri, 29 May 2015 10:46:18 -0600	[thread overview]
Message-ID: <556897DA.1020906@redhat.com> (raw)
In-Reply-To: <1432885880-9847-1-git-send-email-kraxel@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 926 bytes --]

On 05/29/2015 01:51 AM, Gerd Hoffmann wrote:
> Make features 64bit wide everywhere.  Exception: command line flags
> remain 32bit and are copyed into the lower 32 host_features at

s/copyed/copied/

> initialization time.
> 
> On migration a full 64bit guest_features field is sent if one of the
> high bits is set, additionally to the lower 32bit guest_features field

s/additionally/in addition/

> which must stay for compatibility reasons.  That way we send the lower
> 32 feature bits twice, but that way the code is simpler because we don't
> have to split and compose the 64bit features into two 32bit fields.
> 
> This depends on "move host_features" patch by cornelia.

This paragraph could go after the '---' separator.

> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      parent reply	other threads:[~2015-05-29 16:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29  7:51 [Qemu-devel] [PATCH v2] virtio: make features 64bit wide Gerd Hoffmann
2015-05-29 14:53 ` Michael S. Tsirkin
2015-06-01  7:23   ` Gerd Hoffmann
2015-06-01  7:29     ` Michael S. Tsirkin
2015-05-29 16:46 ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=556897DA.1020906@redhat.com \
    --to=eblake@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.