All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, xfs@oss.sgi.com
Subject: [PATCH 1/4] xfsprogs: remove unused write-only var l_logsize
Date: Fri, 29 May 2015 14:03:37 -0500	[thread overview]
Message-ID: <5568B809.1090302@sandeen.net> (raw)
In-Reply-To: <5568B7CE.9030709@redhat.com>

l_logsize is only ever set, and is never read.
Remove it.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
 db/sb.c             |    1 -
 include/libxlog.h   |    1 -
 logprint/logprint.c |    1 -
 repair/phase2.c     |    1 -
 4 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/db/sb.c b/db/sb.c
index cd12f83..991478d 100644
--- a/db/sb.c
+++ b/db/sb.c
@@ -251,7 +251,6 @@ sb_logcheck(void)
 		x.lbsize <<= (mp->m_sb.sb_logsectlog - BBSHIFT);
 
 	log.l_dev = mp->m_logdev_targp;
-	log.l_logsize = BBTOB(log.l_logBBsize);
 	log.l_logBBsize = x.logBBsize;
 	log.l_logBBstart = x.logBBstart;
 	log.l_sectBBsize  = BTOBB(x.lbsize);
diff --git a/include/libxlog.h b/include/libxlog.h
index d6ba9a5..e6d915c 100644
--- a/include/libxlog.h
+++ b/include/libxlog.h
@@ -28,7 +28,6 @@ struct xlog {
 	xfs_mount_t	*l_mp;	        /* mount point */
 	struct xfs_buftarg *l_dev;	        /* dev_t of log */
 	xfs_daddr_t	l_logBBstart;   /* start block of log */
-	int		l_logsize;      /* size of log in bytes */
 	int		l_logBBsize;    /* size of log in 512 byte chunks */
 	int		l_curr_cycle;   /* Cycle number of log writes */
 	int		l_prev_cycle;   /* Cycle # b4 last block increment */
diff --git a/logprint/logprint.c b/logprint/logprint.c
index 960a267..fdf106b 100644
--- a/logprint/logprint.c
+++ b/logprint/logprint.c
@@ -242,7 +242,6 @@ main(int argc, char **argv)
 	ASSERT(x.logBBsize <= INT_MAX);
 
 	log.l_dev = mount.m_logdev_targp;
-	log.l_logsize     = BBTOB(x.logBBsize);
 	log.l_logBBstart  = x.logBBstart;
 	log.l_logBBsize   = x.logBBsize;
 	log.l_sectBBsize  = BTOBB(x.lbsize);
diff --git a/repair/phase2.c b/repair/phase2.c
index 0192346..983aaa7 100644
--- a/repair/phase2.c
+++ b/repair/phase2.c
@@ -50,7 +50,6 @@ zero_log(xfs_mount_t *mp)
 		x.lbsize <<= (mp->m_sb.sb_logsectlog - BBSHIFT);
 
 	log.l_dev = mp->m_logdev_targp;
-	log.l_logsize = BBTOB(x.logBBsize);
 	log.l_logBBsize = x.logBBsize;
 	log.l_logBBstart = x.logBBstart;
 	log.l_sectBBsize  = BTOBB(x.lbsize);
-- 1.7.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2015-05-29 19:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-29 19:02 [PATCH 0/4] xfsprogs: mini patch-bomb Eric Sandeen
2015-05-29 19:03 ` Eric Sandeen [this message]
2015-06-03 17:11   ` [PATCH 1/4] xfsprogs: remove unused write-only var l_logsize Brian Foster
2015-05-29 19:06 ` [PATCH 2/4] xfsprogs: add xlog_is_empty() helper Eric Sandeen
2015-06-03 17:11   ` Brian Foster
2015-05-29 19:13 ` [PATCH 3/4] xfsprogs: rename dont_obfuscate in xfs_metadump Eric Sandeen
2015-06-03 17:11   ` Brian Foster
2015-05-29 19:17 ` [PATCH 4/4] xfsprogs: zero out clean log " Eric Sandeen
2015-06-03 17:11   ` Brian Foster
2015-06-03 20:01     ` Eric Sandeen
2015-06-08 15:06   ` [PATCH 4/4 V2] " Eric Sandeen
2015-06-08 18:29     ` Brian Foster
2015-06-08 18:32       ` Eric Sandeen
2015-06-09 23:35         ` Dave Chinner
2015-06-08 18:46     ` [PATCH 4/4 V3] " Eric Sandeen
2015-06-08 18:50       ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5568B809.1090302@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.