From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: <dougthompson@xmission.com>, <mchehab@osg.samsung.com>,
<linux-edac@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/6] edac, mce_amd_inj: Modify flags attrigute to use string arguments
Date: Fri, 29 May 2015 14:12:47 -0500 [thread overview]
Message-ID: <5568BA2F.4040706@amd.com> (raw)
In-Reply-To: <20150529190542.GQ31435@pd.tnic>
On 5/29/2015 2:05 PM, Borislav Petkov wrote:
> On Fri, May 29, 2015 at 01:20:31PM -0500, Aravind Gopalakrishnan wrote:
>> Hmm. That should work. Will simplify it in the next version.
>> I think I had a NULL in flags_options[] to denote the invalid option.
> Still a good thing to have it as a terminator. But the loop I proposed
> doesn't even touch it: i < N_INJ_TYPES.
Which was exactly why I was thinking of removing it. But..
> I'd leave the NULL array
> terminator.
.. OK. Shall retain.
>> Shall I make err = -EINVAL by default and return that here if the
>> condition is not satisfied?
> We have to make sure to not be overeager to error out - this'll make
> using this facility a bit more cumbersome.
>
> So I think your approach was correct to trim it to MAX_FLAG_OPT_SIZE.
> __set_inj() will catch any string mismatches anyway.
>
OK then, Will retain the original method,
and move the 'ret = cnt' assignment after this check. (Forgot to ack
that in earlier reply)
Thanks,
-Aravind.
next prev parent reply other threads:[~2015-05-29 19:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 19:03 [PATCH 0/6] Updates to EDAC mce_amd_inj Aravind Gopalakrishnan
2015-05-27 19:03 ` [PATCH 1/6] edac, mce_amd_inj: Use MCE_INJECT_GET for bank Aravind Gopalakrishnan
2015-05-27 19:03 ` [PATCH 2/6] edac, mce_amd_inj: Rework sanity check for inj_bank_set Aravind Gopalakrishnan
2015-05-27 19:03 ` [PATCH 3/6] edac, mce_amd_inj: Modify flags attrigute to use string arguments Aravind Gopalakrishnan
2015-05-29 13:49 ` Borislav Petkov
2015-05-29 18:20 ` Aravind Gopalakrishnan
2015-05-29 19:05 ` Borislav Petkov
2015-05-29 19:12 ` Aravind Gopalakrishnan [this message]
2015-06-01 19:16 ` Aravind Gopalakrishnan
2015-05-27 19:03 ` [PATCH 4/6] edac, mce_amd_inj: Add capability to trigger apic interrupts Aravind Gopalakrishnan
2015-05-29 15:36 ` Borislav Petkov
2015-05-29 18:27 ` Aravind Gopalakrishnan
2015-05-29 19:18 ` Borislav Petkov
2015-05-27 19:03 ` [PATCH 5/6] edac, mce_amd_inj: Add README file Aravind Gopalakrishnan
2015-05-29 15:38 ` Borislav Petkov
2015-05-29 18:29 ` Aravind Gopalakrishnan
2015-05-27 19:03 ` [PATCH 6/6] edac, mce_amd_inj: Inject errors on NBC for bank 4 errors Aravind Gopalakrishnan
2015-05-29 16:00 ` Borislav Petkov
2015-05-29 18:52 ` Aravind Gopalakrishnan
2015-05-29 19:23 ` Borislav Petkov
2015-05-29 19:27 ` Aravind Gopalakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5568BA2F.4040706@amd.com \
--to=aravind.gopalakrishnan@amd.com \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.