From: Josh Hunt <johunt@akamai.com>
To: Tom Herbert <tom@herbertland.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [PATCH v2] ipv6: Fix protocol resubmission
Date: Fri, 29 May 2015 21:37:04 -0500 [thread overview]
Message-ID: <55692250.9070500@akamai.com> (raw)
In-Reply-To: <CALx6S34mG6HTtJ5sofLKayMgtJ9EhwCnk9RFX-He8sVBpO9ovg@mail.gmail.com>
On 05/29/2015 04:48 PM, Tom Herbert wrote:
> Hi Josh,
>
> Why did you need to move the resubmit label?
Grabbing nhoff out of the skb's cb didn't seem relevant anymore, unless
we're requiring the decapsulating code to update the control block
before it returns. Also, since we are returning nexthdr with the return
value it seems unnecessary to go through that work when we already have it.
Not that there has to be symmetry here, but for example, the v4 code
doesn't look up the protocol field again in the inner ip header. It just
uses the protocol value returned from the protocol handler.
Also, I'm skipping the pskb_pull(), which I assumed was left up to the
decapsulating code to setup the data pointer properly before returning.
Again, this is how the v4 code behaves.
The only thing left is the idev which I'm not sure about. Could that
change b/t calls?
Josh
next prev parent reply other threads:[~2015-05-30 2:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 20:04 [PATCH v2] ipv6: Fix protocol resubmission Josh Hunt
2015-05-29 20:27 ` Sergei Shtylyov
2015-05-29 21:43 ` Josh Hunt
2015-05-29 21:48 ` Tom Herbert
2015-05-30 2:37 ` Josh Hunt [this message]
2015-06-02 14:32 ` Josh Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55692250.9070500@akamai.com \
--to=johunt@akamai.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.