From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH V5 09/10] xen/arm: make domain_max_vcpus
 return value from vgic_ops
Date: Sun, 31 May 2015 19:05:17 +0100
Message-ID: <556B4D5D.6000503@citrix.com>
References: <1432984051-10838-1-git-send-email-cbz@baozis.org>
	<1432984051-10838-10-git-send-email-cbz@baozis.org>
	<556B0E3E.30106@citrix.com>
	<906BA87F-69AA-4D25-A264-5B6DD3B01C63@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=586dd3b0e=julien.grall@citrix.com>)
	id 1Yz7bv-0004I7-Cw
	for xen-devel@lists.xenproject.org; Sun, 31 May 2015 18:05:23 +0000
In-Reply-To: <906BA87F-69AA-4D25-A264-5B6DD3B01C63@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chen Baozi <baozich@gmail.com>, Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, Chen Baozi <cbz@baozis.org>, Campbell Ian <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi Chen,

On 31/05/2015 16:31, Chen Baozi wrote:
>> On May 31, 2015, at 21:35, Julien Grall <julien.grall@citrix.com> wrote:
>>> +
>>>   #define NR_GIC_LOCAL_IRQS  NR_LOCAL_IRQS
>>>   #define NR_GIC_SGI         16
>>>   #define MAX_RDIST_COUNT    4
>>> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
>>> index 2f413e1..1157b04 100644
>>> --- a/xen/include/asm-arm/vgic.h
>>> +++ b/xen/include/asm-arm/vgic.h
>>> @@ -110,6 +110,8 @@ struct vgic_ops {
>>>       struct vcpu *(*get_target_vcpu)(struct vcpu *v, unsigned int irq);
>>>       /* vGIC sysreg emulation */
>>>       int (*emulate_sysreg)(struct cpu_user_regs *regs, union hsr hsr);
>>> +    /* Get the maximum number of vCPU supported */
>>> +    int (*get_max_vcpus)(void);
>>
>> Why did you create a function? The value never change so a field value w=
ould have been better=85
>
> But is it appropriate that we define a field value in a struct called vgi=
c_ops? I
> thought =91XXX_ops=92 refers to a struct that is made up by function poin=
ts. (FIXME)

Well if the only issue if the name, please rename the structure. IHMO, =

the name is fine for me, I will let Ian & Stefano decides about it.

As the vGIC is always supporting N cpus and will never change, it's =

pointless to use a function (thinking about the "cost" vs access an field).

Regards,

-- =

Julien Grall